Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 55763004: Allow the computation of inflated bounds for non matrix transform operations. (Closed)

Created:
7 years, 1 month ago by Ian Vollick
Modified:
7 years, 1 month ago
Reviewers:
danakj, ajuma, hartmanng
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Allow the computation of inflated bounds for non matrix transform operations. This CL expands the list of transform operations for which we may compute inflated bounds for animation. R=hartmanng@chromium.org,ajuma@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232889

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address reviewer feedback / remove unused functions. #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -159 lines) Patch
M cc/animation/layer_animation_controller_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M cc/animation/transform_operation.cc View 1 7 chunks +37 lines, -112 lines 0 comments Download
M cc/animation/transform_operations_unittest.cc View 1 2 6 chunks +166 lines, -44 lines 0 comments Download
M ui/gfx/box_f.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gfx/box_f.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ian Vollick
7 years, 1 month ago (2013-11-01 20:12:48 UTC) #1
ajuma
https://codereview.chromium.org/55763004/diff/1/cc/animation/transform_operation.cc File cc/animation/transform_operation.cc (right): https://codereview.chromium.org/55763004/diff/1/cc/animation/transform_operation.cc#newcode290 cc/animation/transform_operation.cc:290: } One thing I find confusing is that we ...
7 years, 1 month ago (2013-11-01 21:02:07 UTC) #2
Ian Vollick
https://codereview.chromium.org/55763004/diff/1/cc/animation/transform_operation.cc File cc/animation/transform_operation.cc (right): https://codereview.chromium.org/55763004/diff/1/cc/animation/transform_operation.cc#newcode290 cc/animation/transform_operation.cc:290: } On 2013/11/01 21:02:08, ajuma wrote: > One thing ...
7 years, 1 month ago (2013-11-03 19:05:19 UTC) #3
ajuma
On 2013/11/03 19:05:19, Ian Vollick wrote: > https://codereview.chromium.org/55763004/diff/1/cc/animation/transform_operation.cc > File cc/animation/transform_operation.cc (right): > > https://codereview.chromium.org/55763004/diff/1/cc/animation/transform_operation.cc#newcode290 ...
7 years, 1 month ago (2013-11-04 14:22:25 UTC) #4
ajuma
lgtm
7 years, 1 month ago (2013-11-04 14:22:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/55763004/140001
7 years, 1 month ago (2013-11-04 14:25:02 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34218
7 years, 1 month ago (2013-11-04 14:39:48 UTC) #7
Ian Vollick
+danakj for OWNERS.
7 years, 1 month ago (2013-11-04 15:16:38 UTC) #8
danakj
lgtm
7 years, 1 month ago (2013-11-04 15:41:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/55763004/140001
7 years, 1 month ago (2013-11-04 15:51:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/55763004/140001
7 years, 1 month ago (2013-11-04 17:45:45 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 02:35:34 UTC) #12
Message was sent while issue was closed.
Change committed as 232889

Powered by Google App Engine
This is Rietveld 408576698