Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 557573002: Changes view manager to report visibility and drawn state (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changes view manager to report visibility and drawn state Visibility tracks whether the view itself is visible and drawn whether all the views ancestors are visible and connected to the root. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/949e46b9b265ed9c0fe2c261ab83ffd67b0e2552 Cr-Commit-Position: refs/heads/master@{#293949}

Patch Set 1 #

Patch Set 2 : share code #

Patch Set 3 : update client lib #

Patch Set 4 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -26 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 2 3 2 chunks +21 lines, -1 line 0 comments Download
M mojo/services/view_manager/connection_manager.h View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
M mojo/services/view_manager/connection_manager.cc View 1 2 3 3 chunks +28 lines, -0 lines 0 comments Download
M mojo/services/view_manager/server_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/services/view_manager/server_view.cc View 3 chunks +12 lines, -1 line 0 comments Download
M mojo/services/view_manager/server_view_delegate.h View 2 chunks +6 lines, -1 line 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 4 chunks +11 lines, -0 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 5 chunks +39 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 1 2 3 3 chunks +10 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 1 2 3 5 chunks +67 lines, -6 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 2 3 6 chunks +169 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sky
6 years, 3 months ago (2014-09-08 23:05:34 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 3 months ago (2014-09-09 01:00:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/557573002/40001
6 years, 3 months ago (2014-09-09 14:41:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/6797) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/13192) ios_rel_device ...
6 years, 3 months ago (2014-09-09 14:45:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/557573002/60001
6 years, 3 months ago (2014-09-09 15:17:50 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 61792d94a7b55f22e002962c76e15b85e3207aa8
6 years, 3 months ago (2014-09-09 16:22:15 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:41 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/949e46b9b265ed9c0fe2c261ab83ffd67b0e2552
Cr-Commit-Position: refs/heads/master@{#293949}

Powered by Google App Engine
This is Rietveld 408576698