Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: mojo/services/view_manager/test_change_tracker.cc

Issue 557573002: Changes view manager to report visibility and drawn state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge 2 trunk Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/services/view_manager/test_change_tracker.h" 5 #include "mojo/services/view_manager/test_change_tracker.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "mojo/common/common_type_converters.h" 9 #include "mojo/common/common_type_converters.h"
10 #include "mojo/services/public/cpp/geometry/geometry_type_converters.h" 10 #include "mojo/services/public/cpp/geometry/geometry_type_converters.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 case CHANGE_TYPE_NODE_REORDERED: 52 case CHANGE_TYPE_NODE_REORDERED:
53 return base::StringPrintf("Reordered view=%s relative=%s direction=%s", 53 return base::StringPrintf("Reordered view=%s relative=%s direction=%s",
54 ViewIdToString(change.view_id).c_str(), 54 ViewIdToString(change.view_id).c_str(),
55 ViewIdToString(change.view_id2).c_str(), 55 ViewIdToString(change.view_id2).c_str(),
56 DirectionToString(change.direction).c_str()); 56 DirectionToString(change.direction).c_str());
57 57
58 case CHANGE_TYPE_NODE_DELETED: 58 case CHANGE_TYPE_NODE_DELETED:
59 return base::StringPrintf("ViewDeleted view=%s", 59 return base::StringPrintf("ViewDeleted view=%s",
60 ViewIdToString(change.view_id).c_str()); 60 ViewIdToString(change.view_id).c_str());
61 61
62 case CHANGE_TYPE_NODE_VISIBILITY_CHANGED:
63 return base::StringPrintf("VisibilityChanged view=%s visible=%s",
64 ViewIdToString(change.view_id).c_str(),
65 change.bool_value ? "true" : "false");
66
67 case CHANGE_TYPE_NODE_DRAWN_STATE_CHANGED:
68 return base::StringPrintf("DrawnStateChanged view=%s drawn=%s",
69 ViewIdToString(change.view_id).c_str(),
70 change.bool_value ? "true" : "false");
71
62 case CHANGE_TYPE_INPUT_EVENT: 72 case CHANGE_TYPE_INPUT_EVENT:
63 return base::StringPrintf("InputEvent view=%s event_action=%d", 73 return base::StringPrintf("InputEvent view=%s event_action=%d",
64 ViewIdToString(change.view_id).c_str(), 74 ViewIdToString(change.view_id).c_str(),
65 change.event_action); 75 change.event_action);
76
66 case CHANGE_TYPE_DELEGATE_EMBED: 77 case CHANGE_TYPE_DELEGATE_EMBED:
67 return base::StringPrintf("DelegateEmbed url=%s", 78 return base::StringPrintf("DelegateEmbed url=%s",
68 change.embed_url.data()); 79 change.embed_url.data());
69 } 80 }
70 return std::string(); 81 return std::string();
71 } 82 }
72 83
73 } // namespace 84 } // namespace
74 85
75 std::vector<std::string> ChangesToDescription1( 86 std::vector<std::string> ChangesToDescription1(
(...skipping 10 matching lines...) Expand all
86 std::vector<std::string> view_strings(changes[0].views.size()); 97 std::vector<std::string> view_strings(changes[0].views.size());
87 for (size_t i = 0; i < changes[0].views.size(); ++i) 98 for (size_t i = 0; i < changes[0].views.size(); ++i)
88 view_strings[i] = "[" + changes[0].views[i].ToString() + "]"; 99 view_strings[i] = "[" + changes[0].views[i].ToString() + "]";
89 return JoinString(view_strings, ','); 100 return JoinString(view_strings, ',');
90 } 101 }
91 102
92 TestView ViewDataToTestView(const ViewDataPtr& data) { 103 TestView ViewDataToTestView(const ViewDataPtr& data) {
93 TestView view; 104 TestView view;
94 view.parent_id = data->parent_id; 105 view.parent_id = data->parent_id;
95 view.view_id = data->view_id; 106 view.view_id = data->view_id;
107 view.visible = data->visible;
108 view.drawn = data->drawn;
96 return view; 109 return view;
97 } 110 }
98 111
99 void ViewDatasToTestViews(const Array<ViewDataPtr>& data, 112 void ViewDatasToTestViews(const Array<ViewDataPtr>& data,
100 std::vector<TestView>* test_views) { 113 std::vector<TestView>* test_views) {
101 for (size_t i = 0; i < data.size(); ++i) 114 for (size_t i = 0; i < data.size(); ++i)
102 test_views->push_back(ViewDataToTestView(data[i])); 115 test_views->push_back(ViewDataToTestView(data[i]));
103 } 116 }
104 117
105 Change::Change() 118 Change::Change()
106 : type(CHANGE_TYPE_EMBED), 119 : type(CHANGE_TYPE_EMBED),
107 connection_id(0), 120 connection_id(0),
108 view_id(0), 121 view_id(0),
109 view_id2(0), 122 view_id2(0),
110 view_id3(0), 123 view_id3(0),
111 event_action(0), 124 event_action(0),
112 direction(ORDER_DIRECTION_ABOVE) { 125 direction(ORDER_DIRECTION_ABOVE),
126 bool_value(false) {
113 } 127 }
114 128
115 Change::~Change() { 129 Change::~Change() {
116 } 130 }
117 131
118 TestChangeTracker::TestChangeTracker() 132 TestChangeTracker::TestChangeTracker()
119 : delegate_(NULL) { 133 : delegate_(NULL) {
120 } 134 }
121 135
122 TestChangeTracker::~TestChangeTracker() { 136 TestChangeTracker::~TestChangeTracker() {
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 AddChange(change); 182 AddChange(change);
169 } 183 }
170 184
171 void TestChangeTracker::OnViewDeleted(Id view_id) { 185 void TestChangeTracker::OnViewDeleted(Id view_id) {
172 Change change; 186 Change change;
173 change.type = CHANGE_TYPE_NODE_DELETED; 187 change.type = CHANGE_TYPE_NODE_DELETED;
174 change.view_id = view_id; 188 change.view_id = view_id;
175 AddChange(change); 189 AddChange(change);
176 } 190 }
177 191
192 void TestChangeTracker::OnViewVisibilityChanged(Id view_id, bool visible) {
193 Change change;
194 change.type = CHANGE_TYPE_NODE_VISIBILITY_CHANGED;
195 change.view_id = view_id;
196 change.bool_value = visible;
197 AddChange(change);
198 }
199
200 void TestChangeTracker::OnViewDrawnStateChanged(Id view_id, bool drawn) {
201 Change change;
202 change.type = CHANGE_TYPE_NODE_DRAWN_STATE_CHANGED;
203 change.view_id = view_id;
204 change.bool_value = drawn;
205 AddChange(change);
206 }
207
178 void TestChangeTracker::OnViewInputEvent(Id view_id, EventPtr event) { 208 void TestChangeTracker::OnViewInputEvent(Id view_id, EventPtr event) {
179 Change change; 209 Change change;
180 change.type = CHANGE_TYPE_INPUT_EVENT; 210 change.type = CHANGE_TYPE_INPUT_EVENT;
181 change.view_id = view_id; 211 change.view_id = view_id;
182 change.event_action = event->action; 212 change.event_action = event->action;
183 AddChange(change); 213 AddChange(change);
184 } 214 }
185 215
186 void TestChangeTracker::DelegateEmbed(const String& url) { 216 void TestChangeTracker::DelegateEmbed(const String& url) {
187 Change change; 217 Change change;
188 change.type = CHANGE_TYPE_DELEGATE_EMBED; 218 change.type = CHANGE_TYPE_DELEGATE_EMBED;
189 change.embed_url = url; 219 change.embed_url = url;
190 AddChange(change); 220 AddChange(change);
191 } 221 }
192 222
193 void TestChangeTracker::AddChange(const Change& change) { 223 void TestChangeTracker::AddChange(const Change& change) {
194 changes_.push_back(change); 224 changes_.push_back(change);
195 if (delegate_) 225 if (delegate_)
196 delegate_->OnChangeAdded(); 226 delegate_->OnChangeAdded();
197 } 227 }
198 228
199 std::string TestView::ToString() const { 229 std::string TestView::ToString() const {
200 return base::StringPrintf("view=%s parent=%s", 230 return base::StringPrintf("view=%s parent=%s",
201 ViewIdToString(view_id).c_str(), 231 ViewIdToString(view_id).c_str(),
202 ViewIdToString(parent_id).c_str()); 232 ViewIdToString(parent_id).c_str());
203 } 233 }
204 234
235 std::string TestView::ToString2() const {
236 return base::StringPrintf("view=%s parent=%s visible=%s drawn=%s",
237 ViewIdToString(view_id).c_str(),
238 ViewIdToString(parent_id).c_str(),
239 visible ? "true" : "false",
240 drawn ? "true" : "false");
241 }
242
205 } // namespace service 243 } // namespace service
206 } // namespace mojo 244 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/services/view_manager/test_change_tracker.h ('k') | mojo/services/view_manager/view_manager_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698