Issue 557533003: Subzero: Make sure alloca with align=0 is handled correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 557533003: Subzero: Make sure alloca with align=0 is handled correctly. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth

Modified:
6 years, 3 months ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Make sure alloca with align=0 is handled correctly. 1. Modify dump() to match LLVM. 2. If it weren't for minimum stack alignment, the alignment code would be broken, so add a test in case the alignment code changes. BUG= none R=jvoung@chromium.org, kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=72a8f8d

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
M	src/IceInst.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/alloc.ll	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Jim Stichnoth

6 years, 3 months ago (2014-09-09 00:57:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 72a8f8d (presubmit successful).