src/IceInst.cpp - Issue 557533003: Subzero: Make sure alloca with align=0 is handled correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInst.cpp

Issue 557533003: Subzero: Make sure alloca with align=0 is handled correctly. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Remap align=0 to align=1 in lowering Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInst.cpp

diff --git a/src/IceInst.cpp b/src/IceInst.cpp

index cfcaad3b1fe8e6185cc485d6c78d3d807001862d..43291ced46fb749a926943f93ddbe1c43d1fcb87 100644

--- a/src/IceInst.cpp

+++ b/src/IceInst.cpp

@@ -534,7 +534,8 @@ void InstAlloca::dump(const Cfg *Func) const {

dumpDest(Func);

Str << " = alloca i8, i32 ";

getSizeInBytes()->dump(Func);

- Str << ", align " << getAlignInBytes();

+ if (getAlignInBytes())

+ Str << ", align " << getAlignInBytes();

}

void InstArithmetic::dump(const Cfg *Func) const {

« no previous file with comments | « no previous file | src/IceTargetLoweringX8632.cpp » ('j') | no next file with comments »