chrome/browser/plugin_exceptions_table_model_unittest.cc - Issue 5574001: Move ContentSettingsDetails and Pattern out of HostContentSettingsMap as separate classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugin_exceptions_table_model_unittest.cc

Issue 5574001: Move ContentSettingsDetails and Pattern out of HostContentSettingsMap as separate classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/content_settings

Patch Set: updates Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/content_settings_details.h ('K') | « chrome/browser/plugin_exceptions_table_model.h ('k') | chrome/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugin_exceptions_table_model_unittest.cc

diff --git a/chrome/browser/plugin_exceptions_table_model_unittest.cc b/chrome/browser/plugin_exceptions_table_model_unittest.cc

index 813083c946fa906e22a12fab05a6fbf5da578b2e..61ffdad65be49f9071e21639c6a72d881b3b04d8 100644

--- a/chrome/browser/plugin_exceptions_table_model_unittest.cc

+++ b/chrome/browser/plugin_exceptions_table_model_unittest.cc

@@ -65,8 +65,8 @@ class PluginExceptionsTableModelTest : public testing::Test {

HostContentSettingsMap* map = profile_->GetHostContentSettingsMap();

- HostContentSettingsMap::Pattern example_com("[*.]example.com");

- HostContentSettingsMap::Pattern moose_org("[*.]moose.org");

+ ContentSettingsPattern example_com("[*.]example.com");

+ ContentSettingsPattern moose_org("[*.]moose.org");

map->SetContentSetting(example_com,

CONTENT_SETTINGS_TYPE_PLUGINS,

"a-foo",

@@ -179,7 +179,7 @@ TEST_F(PluginExceptionsTableModelTest, RemoveLastRowInGroup) {

HostContentSettingsMap* map = profile_->GetHostContentSettingsMap();

EXPECT_CALL(observer, OnModelChanged());

- map->SetContentSetting(HostContentSettingsMap::Pattern("[*.]blurp.net"),

+ map->SetContentSetting(ContentSettingsPattern("[*.]blurp.net"),

CONTENT_SETTINGS_TYPE_PLUGINS,

"b-bar",

CONTENT_SETTING_BLOCK);