Move ContentSettingsDetails and Pattern out of HostContentSettingsMap as separate classes.

chrome/browser/content_settings/content_settings_details.h

Index: chrome/browser/content_settings/content_settings_details.h
diff --git a/chrome/browser/content_settings/content_settings_details.h b/chrome/browser/content_settings/content_settings_details.h
new file mode 100644
index 0000000000000000000000000000000000000000..51c54314c11fcebc813069d0c39e0eb698e9f552
--- /dev/null
+++ b/chrome/browser/content_settings/content_settings_details.h
@@ -0,0 +1,56 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// The details send with notifications about content setting changes.
+
+#ifndef CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_DETAILS_H_
+#define CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_DETAILS_H_
+#pragma once
+
+#include "base/basictypes.h"
+#include "chrome/browser/content_settings/content_settings_pattern.h"
+#include "chrome/common/content_settings.h"
+
+// Details for the CONTENT_SETTINGS_CHANGED notification. This is sent when
+// content settings change for at least one host. If settings change for more
+// than one pattern in one user interaction, this will usually send a single

[markusheintz_, 2010/12/02 14:12:28]

There is a deterministic behavior in the host content settings map. Right? At
least there should be.
Whenever you call a set default setting method the signaling notification is
fired and whenever you change the content setting for one specific pattern you
include the the pattern.

If you reset to the default than also more than one pattern changes and hence
you send a signaling notification. I guess the contract should explain the
deterministic behavior on which you can count. Feel free to point me to the
right code location in case I missed something.

+// notification with update_all() returning true instead of one notification
+// for each pattern.
+class ContentSettingsDetails {
+ public:
+  // Update the setting that matches this pattern/content type/resource.
+  ContentSettingsDetails(const ContentSettingsPattern& pattern,
+                         ContentSettingsType type,
+                         const std::string& resource_identifier)
+      : pattern_(pattern),
+        type_(type),
+        resource_identifier_(resource_identifier) {}
+
+  // The pattern whose settings have changed.
+  const ContentSettingsPattern& pattern() const { return pattern_; }
+
+  // True if all settings should be updated for the given type.
+  bool update_all() const { return pattern_.AsString().empty(); }
+
+  // The type of the pattern whose settings have changed.
+  ContentSettingsType type() const { return type_; }
+
+  // The resource identifier for the settings type that has changed.
+  const std::string& resource_identifier() const {
+    return resource_identifier_;
+  }
+
+  // True if all types should be updated. If update_all() is false, this will
+  // be false as well (although the reverse does not hold true).
+  bool update_all_types() const {
+    return CONTENT_SETTINGS_TYPE_DEFAULT == type_;
+  }
+
+ private:
+  ContentSettingsPattern pattern_;
+  ContentSettingsType type_;
+  std::string resource_identifier_;
+};
+
+#endif  // CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_DETAILS_H_