Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 557273003: Remove deprecated extension notification from panel. (Closed)

Created:
6 years, 3 months ago by Jitu( very slow this week)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated extension notification from panel. Remove deprecated extension notification from panel. BUG=411568 Committed: https://crrev.com/c9cd3004692f326e44f8907bf9d2f7cd9deb162b Cr-Commit-Position: refs/heads/master@{#294544}

Patch Set 1 #

Patch Set 2 : Fix failed test #

Patch Set 3 : Rebase panel_browsertest.cc file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -16 lines) Patch
M chrome/browser/ui/panels/panel.h View 5 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 7 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
Jitu( very slow this week)
PTAL...
6 years, 3 months ago (2014-09-10 13:09:30 UTC) #2
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-09-10 13:27:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jitendra.ks@samsung.com/557273003/1
6 years, 3 months ago (2014-09-10 13:59:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9982)
6 years, 3 months ago (2014-09-10 14:06:43 UTC) #7
jianli
lgtm
6 years, 3 months ago (2014-09-10 17:22:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/557273003/1
6 years, 3 months ago (2014-09-11 05:25:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/15169) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/12551)
6 years, 3 months ago (2014-09-11 07:03:28 UTC) #13
Jitu( very slow this week)
Modified the testcase as it was failing in trybot. PTAL ...
6 years, 3 months ago (2014-09-11 10:40:11 UTC) #14
jianli
Still LGTM
6 years, 3 months ago (2014-09-11 17:18:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/557273003/40001
6 years, 3 months ago (2014-09-12 04:58:23 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001) as a6f205672e865c59bda864bd163d6feff88504b4
6 years, 3 months ago (2014-09-12 05:44:10 UTC) #22
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 05:45:50 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c9cd3004692f326e44f8907bf9d2f7cd9deb162b
Cr-Commit-Position: refs/heads/master@{#294544}

Powered by Google App Engine
This is Rietveld 408576698