Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 557273003: Remove deprecated extension notification from panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase panel_browsertest.cc file Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/prefs/pref_service.h" 6 #include "base/prefs/pref_service.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/chrome_notification_types.h" 9 #include "chrome/browser/chrome_notification_types.h"
10 #include "chrome/browser/devtools/devtools_window.h" 10 #include "chrome/browser/devtools/devtools_window.h"
(...skipping 18 matching lines...) Expand all
29 #include "chrome/common/chrome_switches.h" 29 #include "chrome/common/chrome_switches.h"
30 #include "chrome/common/pref_names.h" 30 #include "chrome/common/pref_names.h"
31 #include "chrome/common/url_constants.h" 31 #include "chrome/common/url_constants.h"
32 #include "chrome/test/base/interactive_test_utils.h" 32 #include "chrome/test/base/interactive_test_utils.h"
33 #include "chrome/test/base/ui_test_utils.h" 33 #include "chrome/test/base/ui_test_utils.h"
34 #include "content/public/browser/native_web_keyboard_event.h" 34 #include "content/public/browser/native_web_keyboard_event.h"
35 #include "content/public/browser/notification_service.h" 35 #include "content/public/browser/notification_service.h"
36 #include "content/public/browser/web_contents.h" 36 #include "content/public/browser/web_contents.h"
37 #include "content/public/common/url_constants.h" 37 #include "content/public/common/url_constants.h"
38 #include "content/public/test/browser_test_utils.h" 38 #include "content/public/test/browser_test_utils.h"
39 #include "extensions/browser/extension_registry.h"
39 #include "extensions/common/constants.h" 40 #include "extensions/common/constants.h"
40 #include "net/base/net_util.h" 41 #include "net/base/net_util.h"
41 #include "net/test/url_request/url_request_mock_http_job.h" 42 #include "net/test/url_request/url_request_mock_http_job.h"
42 #include "testing/gtest/include/gtest/gtest.h" 43 #include "testing/gtest/include/gtest/gtest.h"
43 #include "ui/base/hit_test.h" 44 #include "ui/base/hit_test.h"
44 #include "ui/events/event_utils.h" 45 #include "ui/events/event_utils.h"
45 #include "ui/gfx/screen.h" 46 #include "ui/gfx/screen.h"
46 47
47 using content::WebContents; 48 using content::WebContents;
48 49
(...skipping 1362 matching lines...) Expand 10 before | Expand all | Expand 10 after
1411 Panel* panel_other = CreatePanel(extension_app_name_other); 1412 Panel* panel_other = CreatePanel(extension_app_name_other);
1412 1413
1413 content::WindowedNotificationObserver signal( 1414 content::WindowedNotificationObserver signal(
1414 chrome::NOTIFICATION_PANEL_CLOSED, 1415 chrome::NOTIFICATION_PANEL_CLOSED,
1415 content::Source<Panel>(panel)); 1416 content::Source<Panel>(panel));
1416 content::WindowedNotificationObserver signal1( 1417 content::WindowedNotificationObserver signal1(
1417 chrome::NOTIFICATION_PANEL_CLOSED, 1418 chrome::NOTIFICATION_PANEL_CLOSED,
1418 content::Source<Panel>(panel1)); 1419 content::Source<Panel>(panel1));
1419 1420
1420 // Send unload notification on the first extension. 1421 // Send unload notification on the first extension.
1421 extensions::UnloadedExtensionInfo details( 1422 extensions::ExtensionRegistry* registry =
1423 extensions::ExtensionRegistry::Get(browser()->profile());
1424 registry->RemoveEnabled(extension->id());
1425 registry->TriggerOnUnloaded(
1422 extension.get(), extensions::UnloadedExtensionInfo::REASON_UNINSTALL); 1426 extension.get(), extensions::UnloadedExtensionInfo::REASON_UNINSTALL);
1423 content::NotificationService::current()->Notify(
1424 extensions::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,
1425 content::Source<Profile>(browser()->profile()),
1426 content::Details<extensions::UnloadedExtensionInfo>(&details));
1427 1427
1428 // Wait for the panels opened by the first extension to close. 1428 // Wait for the panels opened by the first extension to close.
1429 signal.Wait(); 1429 signal.Wait();
1430 signal1.Wait(); 1430 signal1.Wait();
1431 1431
1432 // Verify that the panel that's left is the panel from the second extension. 1432 // Verify that the panel that's left is the panel from the second extension.
1433 EXPECT_EQ(panel_other, panel_manager->panels()[0]); 1433 EXPECT_EQ(panel_other, panel_manager->panels()[0]);
1434 panel_other->Close(); 1434 panel_other->Close();
1435 } 1435 }
1436 1436
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
1773 #else 1773 #else
1774 #define MAYBE_FocusChangeEventOnMinimize FocusChangeEventOnMinimize 1774 #define MAYBE_FocusChangeEventOnMinimize FocusChangeEventOnMinimize
1775 #endif 1775 #endif
1776 IN_PROC_BROWSER_TEST_F(PanelExtensionApiTest, 1776 IN_PROC_BROWSER_TEST_F(PanelExtensionApiTest,
1777 MAYBE_FocusChangeEventOnMinimize) { 1777 MAYBE_FocusChangeEventOnMinimize) {
1778 // This is needed so the subsequently created panels can be activated. 1778 // This is needed so the subsequently created panels can be activated.
1779 // On a Mac, it transforms background-only test process into foreground one. 1779 // On a Mac, it transforms background-only test process into foreground one.
1780 ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser())); 1780 ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
1781 ASSERT_TRUE(RunExtensionTest("panels/focus_change_on_minimize")) << message_; 1781 ASSERT_TRUE(RunExtensionTest("panels/focus_change_on_minimize")) << message_;
1782 } 1782 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698