Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2872)

Unified Diff: chrome/android/shell/res/layout/suggestion_item.xml

Issue 557263002: Adding option to move suggestion popup item text to omnibox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/shell/res/layout/suggestion_item.xml
diff --git a/ui/android/java/res/layout/dropdown_item.xml b/chrome/android/shell/res/layout/suggestion_item.xml
similarity index 51%
copy from ui/android/java/res/layout/dropdown_item.xml
copy to chrome/android/shell/res/layout/suggestion_item.xml
index bded0ad992682189db918912a3dfb442a160eaaa..6a63e99f8dbbd2bb01e277965950187f94d27467 100644
--- a/ui/android/java/res/layout/dropdown_item.xml
+++ b/chrome/android/shell/res/layout/suggestion_item.xml
@@ -6,11 +6,21 @@
-->
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
- android:id="@+id/dropdown_menu_text"
- android:orientation="vertical"
- android:gravity="center_vertical">
+ android:id="@+id/suggestion_item"
+ android:layout_width="wrap_content"
+ android:layout_height="match_parent"
+ android:gravity="center_vertical"
+ android:orientation="horizontal" >
Bernhard Bauer 2014/09/10 07:53:31 No space before the ">".
ankit 2014/09/10 11:16:55 Done.
- <TextView android:id="@+id/dropdown_label"
+ <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ android:id="@+id/inner_layout"
+ android:layout_width="0dp"
+ android:layout_height="match_parent"
+ android:layout_weight="1"
+ android:orientation="vertical"
+ android:layout_gravity="center_vertical">
+
+ <TextView android:id="@+id/suggestion_item_label"
Bernhard Bauer 2014/09/10 07:53:31 Indent these now they are inside of a new LinearLa
ankit 2014/09/10 11:16:56 Done.
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginStart="10dp"
@@ -20,7 +30,8 @@
android:textAlignment="viewStart"
android:textSize="18sp"
android:includeFontPadding="false"/>
- <TextView android:id="@+id/dropdown_sublabel"
+
+ <TextView android:id="@+id/suggestion_item_sublabel"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginStart="10dp"
@@ -31,4 +42,15 @@
android:singleLine="true"
android:textAlignment="viewStart"
android:includeFontPadding="false"/>
+ </LinearLayout>
+
+ <ImageView
+ android:background="?android:attr/selectableItemBackground"
+ android:id="@+id/suggestion_item_arrow"
+ android:layout_width="50dp"
+ android:layout_height="match_parent"
+ android:gravity="end"
+ android:scaleType="center"
+ android:src="@drawable/suggestion_arrow"/>
</LinearLayout>
+

Powered by Google App Engine
This is Rietveld 408576698