Chromium Code Reviews Chromium Code Reviews
Issue 557263002:
Adding option to move suggestion popup item text to omnibox. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 | 3 |
| 4 Use of this source code is governed by a BSD-style license that can be | 4 Use of this source code is governed by a BSD-style license that can be |
| 5 found in the LICENSE file. | 5 found in the LICENSE file. |
| 6 --> | 6 --> |
| 7 | 7 |
| 8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | 8 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
| 9 android:id="@+id/dropdown_menu_text" | 9 android:id="@+id/suggestion_item" |
| 10 android:orientation="vertical" | 10 android:layout_width="wrap_content" |
| 11 android:gravity="center_vertical"> | 11 android:layout_height="match_parent" |
| 12 android:gravity="center_vertical" | |
| 13 android:orientation="horizontal" > | |
|
Bernhard Bauer
2014/09/10 07:53:31
No space before the ">".
ankit
2014/09/10 11:16:55
Done.
| |
| 12 | 14 |
| 13 <TextView android:id="@+id/dropdown_label" | 15 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
| 16 android:id="@+id/inner_layout" | |
| 17 android:layout_width="0dp" | |
| 18 android:layout_height="match_parent" | |
| 19 android:layout_weight="1" | |
| 20 android:orientation="vertical" | |
| 21 android:layout_gravity="center_vertical"> | |
| 22 | |
| 23 <TextView android:id="@+id/suggestion_item_label" | |
|
Bernhard Bauer
2014/09/10 07:53:31
Indent these now they are inside of a new LinearLa
ankit
2014/09/10 11:16:56
Done.
| |
| 14 android:layout_width="wrap_content" | 24 android:layout_width="wrap_content" |
| 15 android:layout_height="wrap_content" | 25 android:layout_height="wrap_content" |
| 16 android:layout_marginStart="10dp" | 26 android:layout_marginStart="10dp" |
| 17 android:layout_marginEnd="10dp" | 27 android:layout_marginEnd="10dp" |
| 18 android:ellipsize="end" | 28 android:ellipsize="end" |
| 19 android:singleLine="true" | 29 android:singleLine="true" |
| 20 android:textAlignment="viewStart" | 30 android:textAlignment="viewStart" |
| 21 android:textSize="18sp" | 31 android:textSize="18sp" |
| 22 android:includeFontPadding="false"/> | 32 android:includeFontPadding="false"/> |
| 23 <TextView android:id="@+id/dropdown_sublabel" | 33 |
| 34 <TextView android:id="@+id/suggestion_item_sublabel" | |
| 24 android:layout_width="wrap_content" | 35 android:layout_width="wrap_content" |
| 25 android:layout_height="wrap_content" | 36 android:layout_height="wrap_content" |
| 26 android:layout_marginStart="10dp" | 37 android:layout_marginStart="10dp" |
| 27 android:layout_marginEnd="10dp" | 38 android:layout_marginEnd="10dp" |
| 28 android:textSize="14sp" | 39 android:textSize="14sp" |
| 29 android:textColor="#8b8b8b" | 40 android:textColor="#8b8b8b" |
| 30 android:ellipsize="end" | 41 android:ellipsize="end" |
| 31 android:singleLine="true" | 42 android:singleLine="true" |
| 32 android:textAlignment="viewStart" | 43 android:textAlignment="viewStart" |
| 33 android:includeFontPadding="false"/> | 44 android:includeFontPadding="false"/> |
| 45 </LinearLayout> | |
| 46 | |
| 47 <ImageView | |
| 48 android:background="?android:attr/selectableItemBackground" | |
| 49 android:id="@+id/suggestion_item_arrow" | |
| 50 android:layout_width="50dp" | |
| 51 android:layout_height="match_parent" | |
| 52 android:gravity="end" | |
| 53 android:scaleType="center" | |
| 54 android:src="@drawable/suggestion_arrow"/> | |
| 34 </LinearLayout> | 55 </LinearLayout> |
| 56 | |
| OLD | NEW |
