Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: Tools/GardeningServer/model/ct-sheriff-failure-group-data.html

Issue 557173002: Some perf improvements to sheriff-o-matics updates. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/model/ct-failure-group.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/model/ct-sheriff-failure-group-data.html
diff --git a/Tools/GardeningServer/model/ct-sheriff-failure-group-data.html b/Tools/GardeningServer/model/ct-sheriff-failure-group-data.html
index e1f3cfc3a8630a5f70a4da52279ab4f4122fab08..1e20783c4be0d013a46cb0b9a973ea1527035512 100644
--- a/Tools/GardeningServer/model/ct-sheriff-failure-group-data.html
+++ b/Tools/GardeningServer/model/ct-sheriff-failure-group-data.html
@@ -28,4 +28,17 @@ CTSheriffFailureGroupData.prototype.failureKeys = function() {
return failure.keys();
}).flatten();
};
+
+CTSheriffFailureGroupData.prototype.failedOnce = function() {
esprehn 2014/09/10 03:59:13 This is much better.
+ var totalFailures = 0;
+ for (var i = 0; i < this.failures.length; i++) {
+ var resultNodes = this.failures[i].resultNodesByBuilder;
+ for (var r in resultNodes) {
+ totalFailures += resultNodes[r].failingBuildCount;
+ if (totalFailures > 1)
+ return false;
+ }
+ }
+ return totalFailures == 1;
+}
</script>
« no previous file with comments | « Tools/GardeningServer/model/ct-failure-group.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698