Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: Tools/GardeningServer/model/ct-failure-group.html

Issue 557173002: Some perf improvements to sheriff-o-matics updates. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/model/ct-failure-group.html
diff --git a/Tools/GardeningServer/model/ct-failure-group.html b/Tools/GardeningServer/model/ct-failure-group.html
index 1b8565ef14d3e24aeb82aba86ca37a627b09eade..7c707cab1c45c7327a0d8702eb072627c9c1cf97 100644
--- a/Tools/GardeningServer/model/ct-failure-group.html
+++ b/Tools/GardeningServer/model/ct-failure-group.html
@@ -45,16 +45,7 @@ CTFailureGroup.prototype.clearBug = function(bug) {
};
CTFailureGroup.prototype._failedOnce = function() {
- var totalFailures = 0;
- for (var i = 0; i < this.data.dataToExamine().length; i++) {
- var resultNodes = this.data.dataToExamine()[i].resultNodesByBuilder;
- Object.keys(resultNodes, function(r) {
- totalFailures += resultNodes[r].failingBuildCount;
- if (totalFailures > 1)
- return false;
- }.bind(this));
- }
- return totalFailures == 1;
+ return this.data.failedOnce && this.data.failedOnce();
}
CTFailureGroup.prototype._computeProperties = function() {

Powered by Google App Engine
This is Rietveld 408576698