Some perf improvements to sheriff-o-matics updates.

Tools/GardeningServer/model/ct-failure-group.html

Index: Tools/GardeningServer/model/ct-failure-group.html
diff --git a/Tools/GardeningServer/model/ct-failure-group.html b/Tools/GardeningServer/model/ct-failure-group.html
index 1b8565ef14d3e24aeb82aba86ca37a627b09eade..26d51d5545451ee119da235afb4845b8ffbfdc11 100644
--- a/Tools/GardeningServer/model/ct-failure-group.html
+++ b/Tools/GardeningServer/model/ct-failure-group.html
@@ -48,11 +48,11 @@ CTFailureGroup.prototype._failedOnce = function() {
   var totalFailures = 0;
   for (var i = 0; i < this.data.dataToExamine().length; i++) {
     var resultNodes = this.data.dataToExamine()[i].resultNodesByBuilder;

[esprehn, 2014/09/10 02:40:23]

What does dataToExamine() do? Calling it repeatedly in a loop looks suspect
here.

[ojan, 2014/09/10 03:41:18]

Yeah, this isn't right. Particularly, this concept only applies to one of the
types of failure groups.

-    Object.keys(resultNodes, function(r) {
+    for (var r in resultNodes) {
       totalFailures += resultNodes[r].failingBuildCount;
       if (totalFailures > 1)
         return false;
-    }.bind(this));
+    }
   }
   return totalFailures == 1;

[esprehn, 2014/09/10 02:40:23]

This can just return true right? If you got here you must have <= 1
totalFailures.

[ojan, 2014/09/10 03:41:18]

Technically it's possible to have no failures in the list and we'd want to
return false. Not sure that can actually happen in practice though.

 }