Some perf improvements to sheriff-o-matics updates.

Tools/GardeningServer/model/ct-failure-group.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="ct-commit-list.html">
 
 <script>
 function CTFailureGroup(key, data) {
@@ skipping 29 matching lines @@
 
 CTFailureGroup.prototype.clearBug = function(bug) {
   return this._annotate({
     bug: undefined,
   });
 };
 
 CTFailureGroup.prototype._failedOnce = function() {
   var totalFailures = 0;
   for (var i = 0; i < this.data.dataToExamine().length; i++) {
     var resultNodes = this.data.dataToExamine()[i].resultNodesByBuilder;

[esprehn, 2014/09/10 02:40:23]

What does dataToExamine() do? Calling it repeatedly in a loop looks suspect
here.

[ojan, 2014/09/10 03:41:18]

Yeah, this isn't right. Particularly, this concept only applies to one of the
types of failure groups.

-    Object.keys(resultNodes, function(r) {
+    for (var r in resultNodes) {
       totalFailures += resultNodes[r].failingBuildCount;
       if (totalFailures > 1)
         return false;
-    }.bind(this));
+    }
   }
   return totalFailures == 1;

[esprehn, 2014/09/10 02:40:23]

This can just return true right? If you got here you must have <= 1
totalFailures.

[ojan, 2014/09/10 03:41:18]

Technically it's possible to have no failures in the list and we'd want to
return false. Not sure that can actually happen in practice though.

 }
 
 CTFailureGroup.prototype._computeProperties = function() {
   this.isSnoozed = Date.now() < this._annotation.snoozeTime;
   if (this.isSnoozed) {
     this.category = 'snoozed';
   } else {
     if (this._failedOnce()) {
       this.category = 'failedOnce';
     } else {
@@ skipping 58 matching lines @@
   }.bind(this));
 };
 
 CTFailureGroup.fetchAnnotations = function() {
   // FIXME: Fetch annotations from frontend.
   var stored = localStorage.CTFailureGroupAnnotations;
   var annotations = stored ? JSON.parse(stored) : {};
   return Promise.resolve(annotations);
 };
 </script>