Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 557153002: Enable ExtensionApiTest.MessagingUserGesture test (Closed)

Created:
6 years, 3 months ago by Zeeshan Qureshi
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable ExtensionApiTest.MessagingUserGesture test This test was disabled temporarily while changing how the fake UserGestureIndicator is set for tests. Depends on blink patch: https://codereview.chromium.org/518633002/ BUG=408426, 406336 NOTRY=true TBR=jochen@chromium.org Committed: https://crrev.com/9e55d685552542d6d6e323f778369367311277c0 Cr-Commit-Position: refs/heads/master@{#294076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/extension_messages_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Zeeshan Qureshi
Already reviewed and trybots run in https://codereview.chromium.org/521743002/
6 years, 3 months ago (2014-09-10 01:57:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/557153002/1
6 years, 3 months ago (2014-09-10 02:00:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 40a115b034b6e9534f8b38c5ab59b7526c5745df
6 years, 3 months ago (2014-09-10 02:06:48 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:57:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e55d685552542d6d6e323f778369367311277c0
Cr-Commit-Position: refs/heads/master@{#294076}

Powered by Google App Engine
This is Rietveld 408576698