chrome/browser/extensions/extension_messages_apitest.cc - Issue 557153002: Enable ExtensionApiTest.MessagingUserGesture test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_messages_apitest.cc

Issue 557153002: Enable ExtensionApiTest.MessagingUserGesture test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_messages_apitest.cc

diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc

index 3b1b896d7d4236528a7219f4d2c94b1992aba7c6..456d85c95074a555cc50c0756a4bb7bd9df81f31 100644

--- a/chrome/browser/extensions/extension_messages_apitest.cc

+++ b/chrome/browser/extensions/extension_messages_apitest.cc

@@ -991,8 +991,7 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingWithTlsChannelIdTest,

EXPECT_EQ(expected_tls_channel_id_value, tls_channel_id);

}

-// FIXME: Enable after https://codereview.chromium.org/518633002/ lands

-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_MessagingUserGesture) {

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MessagingUserGesture) {

const char kManifest[] = "{"

" \"name\": \"user_gesture\","

" \"version\": \"1.0\","

« no previous file with comments | « no previous file | no next file » | no next file with comments »