Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 557073002: TouchTransformer for software mirroring mode (Closed)

Created:
6 years, 3 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

TouchTransformer for software mirroring mode In software mirroring mode, there is one X root window and it should be associated with both displays (touchscreens). BUG=chrome-os-partner:31466 TEST=tested on Big with clone mode. Committed: https://crrev.com/b03278a7385427ab34ed856df09c36f59f6f66ad Cr-Commit-Position: refs/heads/master@{#294407}

Patch Set 1 #

Total comments: 2

Patch Set 2 : mapping the event correctly for external touchscreen #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -22 lines) Patch
M ash/touch/touch_transformer_controller.cc View 1 2 chunks +40 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Yufeng Shen (Slow to review)
6 years, 3 months ago (2014-09-10 20:10:00 UTC) #2
oshima
https://codereview.chromium.org/557073002/diff/1/ash/touch/touch_transformer_controller.cc File ash/touch/touch_transformer_controller.cc (right): https://codereview.chromium.org/557073002/diff/1/ash/touch/touch_transformer_controller.cc#newcode243 ash/touch/touch_transformer_controller.cc:243: display1_id, display2_id); Does this work even if the touch ...
6 years, 3 months ago (2014-09-10 22:34:57 UTC) #3
Yufeng Shen (Slow to review)
https://codereview.chromium.org/557073002/diff/1/ash/touch/touch_transformer_controller.cc File ash/touch/touch_transformer_controller.cc (right): https://codereview.chromium.org/557073002/diff/1/ash/touch/touch_transformer_controller.cc#newcode243 ash/touch/touch_transformer_controller.cc:243: display1_id, display2_id); On 2014/09/10 22:34:56, oshima wrote: > Does ...
6 years, 3 months ago (2014-09-11 01:14:31 UTC) #4
oshima
lgtm
6 years, 3 months ago (2014-09-11 08:13:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/557073002/20001
6 years, 3 months ago (2014-09-11 15:59:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 99d1c4c595c4a312e1ad05ff7fc6ef74e8af1678
6 years, 3 months ago (2014-09-11 17:03:58 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 17:15:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b03278a7385427ab34ed856df09c36f59f6f66ad
Cr-Commit-Position: refs/heads/master@{#294407}

Powered by Google App Engine
This is Rietveld 408576698