Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: ash/touch/touch_transformer_controller.cc

Issue 557073002: TouchTransformer for software mirroring mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mapping the event correctly for external touchscreen Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/touch/touch_transformer_controller.cc
diff --git a/ash/touch/touch_transformer_controller.cc b/ash/touch/touch_transformer_controller.cc
index b99cb5a0571a804b3c6db8a302c4f08a94b9b080..828a47b5c9a06bbf32355ce316f4c8559e95bb4d 100644
--- a/ash/touch/touch_transformer_controller.cc
+++ b/ash/touch/touch_transformer_controller.cc
@@ -197,7 +197,6 @@ void TouchTransformerController::UpdateTouchTransformer() const {
return;
} else if (display_state == ui::MULTIPLE_DISPLAY_STATE_DUAL_MIRROR ||
display_state == ui::MULTIPLE_DISPLAY_STATE_DUAL_EXTENDED) {
- // TODO(miletus) : Handle DUAL_EXTENDED with software mirroring.
DisplayIdPair id_pair = GetDisplayManager()->GetCurrentDisplayIdPair();
display1_id = id_pair.first;
display2_id = id_pair.second;
@@ -236,29 +235,48 @@ void TouchTransformerController::UpdateTouchTransformer() const {
}
if (display_state == ui::MULTIPLE_DISPLAY_STATE_DUAL_EXTENDED) {
- // TODO(miletus) : Handle the case the state is DUAL_EXTENDED but it
- // is actually doing software mirroring.
- if (GetDisplayManager()->software_mirroring_enabled())
- return;
- // In extended mode, each display is associated with one root window.
- aura::Window* root1 =
- display_controller->GetRootWindowForDisplayId(display1_id);
- aura::Window* root2 =
- display_controller->GetRootWindowForDisplayId(display2_id);
- RootWindowController::ForWindow(root1)->ash_host()->UpdateDisplayID(
- display1_id, gfx::Display::kInvalidDisplayID);
- RootWindowController::ForWindow(root2)->ash_host()->UpdateDisplayID(
- display2_id, gfx::Display::kInvalidDisplayID);
gfx::Size fb_size =
Shell::GetInstance()->display_configurator()->framebuffer_size();
- device_manager->UpdateTouchInfoForDisplay(
- display1_id,
- display1.touch_device_id(),
- GetExtendedModeTouchTransformer(display1, fb_size));
- device_manager->UpdateTouchInfoForDisplay(
- display2_id,
- display2.touch_device_id(),
- GetExtendedModeTouchTransformer(display2, fb_size));
+ // In extended but software mirroring mode, ther is only one X root window
+ // that associates with both displays.
+ if (GetDisplayManager()->software_mirroring_enabled()) {
+ aura::Window* root = display_controller->GetPrimaryRootWindow();
+ RootWindowController::ForWindow(root)->ash_host()->UpdateDisplayID(
+ display1_id, display2_id);
+ DisplayInfo source_display =
+ gfx::Display::InternalDisplayId() == display1_id ?
+ display1 : display2;
+ // Mapping from framebuffer size to the source display's native
+ // resolution.
+ device_manager->UpdateTouchInfoForDisplay(
+ display1_id,
+ display1.touch_device_id(),
+ GetExtendedModeTouchTransformer(source_display, fb_size));
+ device_manager->UpdateTouchInfoForDisplay(
+ display2_id,
+ display2.touch_device_id(),
+ GetExtendedModeTouchTransformer(source_display, fb_size));
+ } else {
+ // In actual extended mode, each display is associated with one root
+ // window.
+ aura::Window* root1 =
+ display_controller->GetRootWindowForDisplayId(display1_id);
+ aura::Window* root2 =
+ display_controller->GetRootWindowForDisplayId(display2_id);
+ RootWindowController::ForWindow(root1)->ash_host()->UpdateDisplayID(
+ display1_id, gfx::Display::kInvalidDisplayID);
+ RootWindowController::ForWindow(root2)->ash_host()->UpdateDisplayID(
+ display2_id, gfx::Display::kInvalidDisplayID);
+ // Mapping from framebuffer size to each display's native resolution.
+ device_manager->UpdateTouchInfoForDisplay(
+ display1_id,
+ display1.touch_device_id(),
+ GetExtendedModeTouchTransformer(display1, fb_size));
+ device_manager->UpdateTouchInfoForDisplay(
+ display2_id,
+ display2.touch_device_id(),
+ GetExtendedModeTouchTransformer(display2, fb_size));
+ }
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698