DevTools: extract TracingManager from TracingModel

DevTools: extract TracingManager from TracingModel

Let TracingManager handle back-end interactions while TracingModel
acts just as a container for trace events. The model will later be
moved out of sdk and this will allow introducing backing storage for
trace events (e.g. a file).

BUG=412709
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181741

[caseq, 2014-09-10 09:39:15]

caseq@chromium.org changed reviewers:
+ loislo@chromium.org, yurys@chromium.org

[yurys, 2014-09-10 09:57:43]

lgtm

https://codereview.chromium.org/557013005/diff/1/Source/devtools/front_end/sd...
File Source/devtools/front_end/sdk/TracingModel.js (right):

https://codereview.chromium.org/557013005/diff/1/Source/devtools/front_end/sd...
Source/devtools/front_end/sdk/TracingModel.js:40:
WebInspector.TracingManager.EventPayload;
Can we move it somewhere else to avoid dependency TracingModel ->
TracingManager? We can probably describe this type in the protocol.json and drop
this typedef, wdyt?

https://codereview.chromium.org/557013005/diff/1/Source/devtools/front_end/sd...
Source/devtools/front_end/sdk/TracingModel.js:825: {
How do we handle console.timeline initiated recording after this is removed?

[loislo, 2014-09-10 09:59:11]

https://codereview.chromium.org/557013005/diff/1/LayoutTests/inspector/tracin...
File LayoutTests/inspector/tracing.html (right):

https://codereview.chromium.org/557013005/diff/1/LayoutTests/inspector/tracin...
LayoutTests/inspector/tracing.html:74:
tracingManager.addEventListener(WebInspector.TracingManager.Events.EventsCollected,
 onEventsCollected);
style: extra space

https://codereview.chromium.org/557013005/diff/1/LayoutTests/inspector/tracin...
LayoutTests/inspector/tracing.html:81: tracingManager.stop(onTracingComplete);
looks like it would be called twice. Is it expected.

https://codereview.chromium.org/557013005/diff/1/LayoutTests/inspector/tracin...
LayoutTests/inspector/tracing.html:84: function onEventsCollected(event)
style: new line

[yurys, 2014-09-10 09:59:24]

Oops, hit wrong button instead of "Publish all my drafts". I'm still wondering
whether it will break console.timeline/timelineEnd.

[loislo, 2014-09-10 10:00:50]

On 2014/09/10 09:59:11, loislo wrote:
>
https://codereview.chromium.org/557013005/diff/1/LayoutTests/inspector/tracin...
> File LayoutTests/inspector/tracing.html (right):
> 
>
https://codereview.chromium.org/557013005/diff/1/LayoutTests/inspector/tracin...
> LayoutTests/inspector/tracing.html:74:
>
tracingManager.addEventListener(WebInspector.TracingManager.Events.EventsCollected,
>  onEventsCollected);
> style: extra space
> 
>
https://codereview.chromium.org/557013005/diff/1/LayoutTests/inspector/tracin...
> LayoutTests/inspector/tracing.html:81: tracingManager.stop(onTracingComplete);
> looks like it would be called twice. Is it expected.

I meant onTracingComplete


> 
>
https://codereview.chromium.org/557013005/diff/1/LayoutTests/inspector/tracin...
> LayoutTests/inspector/tracing.html:84: function onEventsCollected(event)
> style: new line

[caseq, 2014-09-10 11:59:57]

https://codereview.chromium.org/557013005/diff/1/LayoutTests/inspector/tracin...
File LayoutTests/inspector/tracing.html (right):

https://codereview.chromium.org/557013005/diff/1/LayoutTests/inspector/tracin...
LayoutTests/inspector/tracing.html:81: tracingManager.stop(onTracingComplete);
On 2014/09/10 09:59:11, loislo wrote:
> looks like it would be called twice. Is it expected.

It's been there before and it's not really used in a call to stop(), but thanks
for noting! Now calling stop() without parameters.

https://codereview.chromium.org/557013005/diff/1/LayoutTests/inspector/tracin...
LayoutTests/inspector/tracing.html:84: function onEventsCollected(event)
On 2014/09/10 09:59:11, loislo wrote:
> style: new line

done.

https://codereview.chromium.org/557013005/diff/1/Source/devtools/front_end/sd...
File Source/devtools/front_end/sdk/TracingModel.js (right):

https://codereview.chromium.org/557013005/diff/1/Source/devtools/front_end/sd...
Source/devtools/front_end/sdk/TracingModel.js:40:
WebInspector.TracingManager.EventPayload;
On 2014/09/10 09:57:42, yurys wrote:
> Can we move it somewhere else to avoid dependency TracingModel ->
> TracingManager? We can probably describe this type in the protocol.json and
drop
> this typedef, wdyt?

I like the idea, but let's do it as a separate change -- there will be a large
diff if we're also about to move Phase enum.

https://codereview.chromium.org/557013005/diff/1/Source/devtools/front_end/sd...
Source/devtools/front_end/sdk/TracingModel.js:825: {
On 2014/09/10 09:57:42, yurys wrote:
> How do we handle console.timeline initiated recording after this is removed?

Reverted this one. Sorry, got a bit carried away with refactoring :-)

[yurys, 2014-09-10 15:15:49]

lgtm

[caseq, 2014-09-10 15:18:21]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2014-09-10 15:18:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/caseq@chromium.org/557013005/20001

[commit-bot: I haz the power, 2014-09-10 16:23:46]

Committed patchset #2 (id:20001) as 181741