Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/inspector/tracing.html

Issue 557013005: DevTools: extract TracingManager from TracingModel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | LayoutTests/inspector/tracing-test.js » ('j') | Source/devtools/front_end/sdk/TracingModel.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <style> 3 <style>
4 div#test { 4 div#test {
5 display: none; 5 display: none;
6 background-color: blue; 6 background-color: blue;
7 width: 100px; 7 width: 100px;
8 height: 100px; 8 height: 100px;
9 } 9 }
10 </style> 10 </style>
11 <script src="../http/tests/inspector/inspector-test.js"></script> 11 <script src="../http/tests/inspector/inspector-test.js"></script>
12 <script> 12 <script>
13 function doWork() 13 function doWork()
14 { 14 {
15 var element = document.getElementById("test"); 15 var element = document.getElementById("test");
16 element.style.display = "block"; 16 element.style.display = "block";
17 var unused = element.clientWidth; 17 var unused = element.clientWidth;
18 } 18 }
19 19
20 function test() 20 function test()
21 { 21 {
22 WebInspector.inspectorView.showPanel("timeline"); 22 WebInspector.inspectorView.showPanel("timeline");
23 23
24 var tracingManager = new WebInspector.TracingManager();
25 var tracingModel = new WebInspector.TracingModel();
26
24 function runEventsSanityCheck() 27 function runEventsSanityCheck()
25 { 28 {
26 var events = []; 29 var events = [];
27 var phaseComplete = 0; 30 var phaseComplete = 0;
28 var knownEvents = {}; 31 var knownEvents = {};
29 var processes = 0; 32 var processes = 0;
30 var threads = 0; 33 var threads = 0;
31 34
32 tracingModel.sortedProcesses().forEach(function(process) { 35 tracingModel.sortedProcesses().forEach(function(process) {
33 processes++; 36 processes++;
(...skipping 20 matching lines...) Expand all
54 InspectorTest.assertGreaterOrEqual(knownEvents["Document::updateRenderTr ee"], 1, "Too few Document::recalcStyle"); 57 InspectorTest.assertGreaterOrEqual(knownEvents["Document::updateRenderTr ee"], 1, "Too few Document::recalcStyle");
55 InspectorTest.assertGreaterOrEqual(knownEvents["FrameView::layout"], 1, "Too few FrameView::layout"); 58 InspectorTest.assertGreaterOrEqual(knownEvents["FrameView::layout"], 1, "Too few FrameView::layout");
56 InspectorTest.assertGreaterOrEqual(phaseComplete, 50, "Too few begin eve nts"); 59 InspectorTest.assertGreaterOrEqual(phaseComplete, 50, "Too few begin eve nts");
57 InspectorTest.assertGreaterOrEqual(processes, 2, "Too few processes"); 60 InspectorTest.assertGreaterOrEqual(processes, 2, "Too few processes");
58 InspectorTest.assertGreaterOrEqual(threads, 4, "Too few threads"); 61 InspectorTest.assertGreaterOrEqual(threads, 4, "Too few threads");
59 InspectorTest.addResult("Event sanity test done"); 62 InspectorTest.addResult("Event sanity test done");
60 } 63 }
61 64
62 function onTracingComplete() 65 function onTracingComplete()
63 { 66 {
64 tracingModel.removeEventListener(WebInspector.TracingModel.Events.Tracin gComplete, onTracingComplete); 67 tracingManager.removeEventListener(WebInspector.TracingManager.Events.Tr acingComplete, onTracingComplete);
65 InspectorTest.addResult("Tracing complete"); 68 InspectorTest.addResult("Tracing complete");
66 runEventsSanityCheck(); 69 runEventsSanityCheck();
67 InspectorTest.completeTest(); 70 InspectorTest.completeTest();
68 } 71 }
69 72
70 var tracingModel = new WebInspector.TracingModel(WebInspector.targetManager. mainTarget()); 73 tracingManager.start("", "", onTracingStarted);
71 tracingModel.start("", "", onTracingStarted); 74 tracingManager.addEventListener(WebInspector.TracingManager.Events.EventsCol lected, onEventsCollected);
loislo 2014/09/10 09:59:11 style: extra space
72 function onTracingStarted(error) 75 function onTracingStarted(error)
73 { 76 {
74 InspectorTest.addResult("Tracing started (error: " + JSON.stringify(erro r) + ")"); 77 InspectorTest.addResult("Tracing started (error: " + JSON.stringify(erro r) + ")");
78 tracingModel.reset();
75 InspectorTest.evaluateInPage("doWork()", function() { 79 InspectorTest.evaluateInPage("doWork()", function() {
76 tracingModel.addEventListener(WebInspector.TracingModel.Events.Traci ngComplete, onTracingComplete); 80 tracingManager.addEventListener(WebInspector.TracingManager.Events.T racingComplete, onTracingComplete);
77 tracingModel.stop(onTracingComplete); 81 tracingManager.stop(onTracingComplete);
loislo 2014/09/10 09:59:11 looks like it would be called twice. Is it expecte
caseq 2014/09/10 11:59:56 It's been there before and it's not really used in
78 }); 82 });
79 } 83 }
84 function onEventsCollected(event)
loislo 2014/09/10 09:59:11 style: new line
caseq 2014/09/10 11:59:56 done.
85 {
86 tracingModel.addEvents(event.data);
87 }
80 } 88 }
81 89
82 </script> 90 </script>
83 </head> 91 </head>
84 <body onload="runTest()"> 92 <body onload="runTest()">
85 <div id="test"> 93 <div id="test">
86 </div> 94 </div>
87 </body> 95 </body>
88 </html> 96 </html>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/inspector/tracing-test.js » ('j') | Source/devtools/front_end/sdk/TracingModel.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698