net/proxy/proxy_service_unittest.cc - Issue 556933003: Pass in bad proxy to NotifyProxyFallback and not the successful one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_service_unittest.cc

Issue 556933003: Pass in bad proxy to NotifyProxyFallback and not the successful one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add all files to cl Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_service_unittest.cc

diff --git a/net/proxy/proxy_service_unittest.cc b/net/proxy/proxy_service_unittest.cc

index f153fad2cceeda9189e621c575a9e8234993b90b..a222710bd216b27f45578da83d4f6486e9e45323 100644

--- a/net/proxy/proxy_service_unittest.cc

+++ b/net/proxy/proxy_service_unittest.cc

@@ -962,7 +962,7 @@ TEST_F(ProxyServiceTest, ProxyFallback) {

// first proxy as bad.

TestProxyFallbackNetworkDelegate test_delegate;

service.ReportSuccess(info, &test_delegate);

- EXPECT_EQ(info.proxy_server(), test_delegate.proxy_server());

+ EXPECT_EQ("foopy1:8080", test_delegate.proxy_server().ToURI());

EXPECT_EQ(net::ERR_PROXY_CONNECTION_FAILED,

test_delegate.proxy_fallback_net_error());

« net/proxy/proxy_service.cc ('K') | « net/proxy/proxy_service.cc ('k') | no next file » | no next file with comments »