Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: net/proxy/proxy_service.cc

Issue 556933003: Pass in bad proxy to NotifyProxyFallback and not the successful one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add all files to cl Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/proxy/proxy_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_service.cc
diff --git a/net/proxy/proxy_service.cc b/net/proxy/proxy_service.cc
index 4c59024746da2662e643bf8f4568d0c9a124d645..9b0b731c637f6b2734483a3801bd3fdc51a3ef91 100644
--- a/net/proxy/proxy_service.cc
+++ b/net/proxy/proxy_service.cc
@@ -1249,8 +1249,10 @@ void ProxyService::ReportSuccess(const ProxyInfo& result,
if (existing == proxy_retry_info_.end()) {
proxy_retry_info_[iter->first] = iter->second;
if (network_delegate) {
+ const ProxyServer& bad_proxy =
+ ProxyServer::FromURI(iter->first, ProxyServer::SCHEME_HTTP);
const ProxyRetryInfo& proxy_retry_info = iter->second;
bengr 2014/09/09 20:43:30 Is it correct to always use SCHEME_HTTP?
Not at Google. Contact bengr 2014/09/09 20:51:29 SCHEME_HTTP is the default used by the net stack a
- network_delegate->NotifyProxyFallback(result.proxy_server(),
+ network_delegate->NotifyProxyFallback(bad_proxy,
proxy_retry_info.net_error);
}
}
« no previous file with comments | « no previous file | net/proxy/proxy_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698