Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 556923002: Use WebLocalFrame::isLoading(), not WebFrame::isLoading(), in print preview. (Closed)

Created:
6 years, 3 months ago by Nate Chapin
Modified:
6 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use WebLocalFrame::isLoading(), not WebFrame::isLoading(), in print preview. This was changed in the normal chromium print_preview_web_helper.cc in 02cfd5ccc819ce649db8ff032d43fb16ee3167d9, but I missed the need to change it in android's print_preview_web_helper.cc. This will allow isLoading() to live solely on WebLocalFrame, as it doesn't make sense in a remote frame. BUG= Committed: https://crrev.com/8ef0627a42fd6a5b07bb16e33a5766673e7bf1d7 Cr-Commit-Position: refs/heads/master@{#294022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/renderer/print_web_view_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Nate Chapin
boliu, would you mind reviewing this simple 1-liner?
6 years, 3 months ago (2014-09-09 17:26:57 UTC) #2
boliu
lgtm
6 years, 3 months ago (2014-09-09 17:28:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/556923002/1
6 years, 3 months ago (2014-09-09 17:33:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/6925)
6 years, 3 months ago (2014-09-09 20:03:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/556923002/1
6 years, 3 months ago (2014-09-09 20:14:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8064a7b4bc3756e4a916a98cbad3f4e15ba233ee
6 years, 3 months ago (2014-09-09 22:44:24 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ef0627a42fd6a5b07bb16e33a5766673e7bf1d7
Cr-Commit-Position: refs/heads/master@{#294022}

Powered by Google App Engine
This is Rietveld 408576698