android_webview/renderer/print_web_view_helper.cc - Issue 556923002: Use WebLocalFrame::isLoading(), not WebFrame::isLoading(), in print preview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/renderer/print_web_view_helper.cc

Issue 556923002: Use WebLocalFrame::isLoading(), not WebFrame::isLoading(), in print preview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/renderer/print_web_view_helper.cc

diff --git a/android_webview/renderer/print_web_view_helper.cc b/android_webview/renderer/print_web_view_helper.cc

index c4a491c68d65570379578baa683b0bd88a628669..cc5beabba2914a78fc9ca8ed3528efcae852db21 100644

--- a/android_webview/renderer/print_web_view_helper.cc

+++ b/android_webview/renderer/print_web_view_helper.cc

@@ -724,7 +724,7 @@ void PrepareFrameAndViewForPrint::RestoreSize() {

}

void PrepareFrameAndViewForPrint::FinishPrinting() {

- blink::WebFrame* frame = frame_.GetFrame();

+ blink::WebLocalFrame* frame = frame_.GetFrame();

if (frame) {

blink::WebView* web_view = frame->view();

if (is_printing_started_) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »