Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 556723003: Terminated extensions should be uninstalled without error now. (Closed)

Created:
6 years, 3 months ago by Alexander Dunaev
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Terminated extensions should be uninstalled without error now. For extensions that have been terminated, attempts to uninstall them via the chrome.management.uninstall call caused an "Extension not found" error because such extensions weren't included in the search. R=rockot@chromium.org BUG=412252 Committed: https://crrev.com/a7cbc07a0d545d7da4e664618c83a50c7336702f Cr-Commit-Position: refs/heads/master@{#293906}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Code review issues are addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/api/management/management_api.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Alexander Dunaev
6 years, 3 months ago (2014-09-09 04:58:22 UTC) #1
Ken Rockot(use gerrit already)
Can you please file a bug for this and include a ref to it in ...
6 years, 3 months ago (2014-09-09 05:55:29 UTC) #2
Alexander Dunaev
Done. I'll send the patch to the commit queue now. Thank you.
6 years, 3 months ago (2014-09-09 06:31:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/voodoo@yandex-team.ru/556723003/20001
6 years, 3 months ago (2014-09-09 06:34:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c94f2971e1248954ab93e9ef1a34bf3d8239cb95
6 years, 3 months ago (2014-09-09 09:35:32 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:52:20 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7cbc07a0d545d7da4e664618c83a50c7336702f
Cr-Commit-Position: refs/heads/master@{#293906}

Powered by Google App Engine
This is Rietveld 408576698