chrome/browser/extensions/api/management/management_api.cc - Issue 556723003: Terminated extensions should be uninstalled without error now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 556723003: Terminated extensions should be uninstalled without error now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review issues are addressed. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index 236e2ef94535295ec2b391a6242dea05517ccc9e..3ee2bcd2347816d3e8fecb9eb4d1ed734eda0401 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -599,7 +599,8 @@ bool ManagementUninstallFunctionBase::Uninstall(

bool show_confirm_dialog) {

extension_id_ = target_extension_id;

const Extension* target_extension =

- service()->GetExtensionById(extension_id_, true);

+ extensions::ExtensionRegistry::Get(browser_context())->

+ GetExtensionById(extension_id_, ExtensionRegistry::EVERYTHING);

if (!target_extension ||

ui_util::ShouldNotBeVisible(target_extension, browser_context())) {

error_ = ErrorUtils::FormatErrorMessage(

« no previous file with comments | « no previous file | no next file » | no next file with comments »