Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: content/test/test_render_frame_host.cc

Issue 556703004: Remove page id from FrameNavigateParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/test_render_frame_host.h ('k') | content/test/test_render_view_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_render_frame_host.cc
diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc
index 598ee5d0605025e5ac9d494d88a5d0eae1da6bca..96b007e46c012ea3548584a2b56e9e60aca3eba6 100644
--- a/content/test/test_render_frame_host.cc
+++ b/content/test/test_render_frame_host.cc
@@ -117,7 +117,9 @@ void TestRenderFrameHost::SendNavigateWithFile(
}
void TestRenderFrameHost::SendNavigateWithParams(
+ int page_id,
FrameHostMsg_DidCommitProvisionalLoad_Params* params) {
+ OnDidAssignPageId(page_id);
FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), *params);
OnDidCommitProvisionalLoad(msg);
}
@@ -139,7 +141,6 @@ void TestRenderFrameHost::SendNavigateWithParameters(
const base::FilePath* file_path_for_history_item,
const std::vector<GURL>& redirects) {
FrameHostMsg_DidCommitProvisionalLoad_Params params;
- params.page_id = page_id;
params.url = url;
params.referrer = Referrer();
params.transition = transition;
@@ -170,6 +171,7 @@ void TestRenderFrameHost::SendNavigateWithParameters(
file_path_for_history_item ? "data" : NULL,
file_path_for_history_item);
+ OnDidAssignPageId(page_id);
FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), params);
OnDidCommitProvisionalLoad(msg);
}
« no previous file with comments | « content/test/test_render_frame_host.h ('k') | content/test/test_render_view_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698