Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: content/test/test_render_frame_host.cc

Issue 556703004: Remove page id from FrameNavigateParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/test_render_frame_host.h ('k') | content/test/test_render_view_host.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/test/test_render_frame_host.h" 5 #include "content/test/test_render_frame_host.h"
6 6
7 #include "content/browser/frame_host/frame_tree.h" 7 #include "content/browser/frame_host/frame_tree.h"
8 #include "content/browser/frame_host/render_frame_host_delegate.h" 8 #include "content/browser/frame_host/render_frame_host_delegate.h"
9 #include "content/common/frame_messages.h" 9 #include "content/common/frame_messages.h"
10 #include "content/test/test_render_view_host.h" 10 #include "content/test/test_render_view_host.h"
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 110
111 void TestRenderFrameHost::SendNavigateWithFile( 111 void TestRenderFrameHost::SendNavigateWithFile(
112 int page_id, 112 int page_id,
113 const GURL& url, 113 const GURL& url,
114 const base::FilePath& file_path) { 114 const base::FilePath& file_path) {
115 SendNavigateWithParameters(page_id, url, ui::PAGE_TRANSITION_LINK, url, 200, 115 SendNavigateWithParameters(page_id, url, ui::PAGE_TRANSITION_LINK, url, 200,
116 &file_path, std::vector<GURL>()); 116 &file_path, std::vector<GURL>());
117 } 117 }
118 118
119 void TestRenderFrameHost::SendNavigateWithParams( 119 void TestRenderFrameHost::SendNavigateWithParams(
120 int page_id,
120 FrameHostMsg_DidCommitProvisionalLoad_Params* params) { 121 FrameHostMsg_DidCommitProvisionalLoad_Params* params) {
122 OnDidAssignPageId(page_id);
121 FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), *params); 123 FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), *params);
122 OnDidCommitProvisionalLoad(msg); 124 OnDidCommitProvisionalLoad(msg);
123 } 125 }
124 126
125 void TestRenderFrameHost::SendNavigateWithRedirects( 127 void TestRenderFrameHost::SendNavigateWithRedirects(
126 int page_id, 128 int page_id,
127 const GURL& url, 129 const GURL& url,
128 const std::vector<GURL>& redirects) { 130 const std::vector<GURL>& redirects) {
129 SendNavigateWithParameters( 131 SendNavigateWithParameters(
130 page_id, url, ui::PAGE_TRANSITION_LINK, url, 200, 0, redirects); 132 page_id, url, ui::PAGE_TRANSITION_LINK, url, 200, 0, redirects);
131 } 133 }
132 134
133 void TestRenderFrameHost::SendNavigateWithParameters( 135 void TestRenderFrameHost::SendNavigateWithParameters(
134 int page_id, 136 int page_id,
135 const GURL& url, 137 const GURL& url,
136 ui::PageTransition transition, 138 ui::PageTransition transition,
137 const GURL& original_request_url, 139 const GURL& original_request_url,
138 int response_code, 140 int response_code,
139 const base::FilePath* file_path_for_history_item, 141 const base::FilePath* file_path_for_history_item,
140 const std::vector<GURL>& redirects) { 142 const std::vector<GURL>& redirects) {
141 FrameHostMsg_DidCommitProvisionalLoad_Params params; 143 FrameHostMsg_DidCommitProvisionalLoad_Params params;
142 params.page_id = page_id;
143 params.url = url; 144 params.url = url;
144 params.referrer = Referrer(); 145 params.referrer = Referrer();
145 params.transition = transition; 146 params.transition = transition;
146 params.redirects = redirects; 147 params.redirects = redirects;
147 params.should_update_history = true; 148 params.should_update_history = true;
148 params.searchable_form_url = GURL(); 149 params.searchable_form_url = GURL();
149 params.searchable_form_encoding = std::string(); 150 params.searchable_form_encoding = std::string();
150 params.security_info = std::string(); 151 params.security_info = std::string();
151 params.gesture = NavigationGestureUser; 152 params.gesture = NavigationGestureUser;
152 params.contents_mime_type = contents_mime_type_; 153 params.contents_mime_type = contents_mime_type_;
(...skipping 10 matching lines...) Expand all
163 transition != ui::PAGE_TRANSITION_TYPED && 164 transition != ui::PAGE_TRANSITION_TYPED &&
164 url.ReplaceComponents(replacements) == 165 url.ReplaceComponents(replacements) ==
165 GetLastCommittedURL().ReplaceComponents(replacements); 166 GetLastCommittedURL().ReplaceComponents(replacements);
166 167
167 params.page_state = PageState::CreateForTesting( 168 params.page_state = PageState::CreateForTesting(
168 url, 169 url,
169 false, 170 false,
170 file_path_for_history_item ? "data" : NULL, 171 file_path_for_history_item ? "data" : NULL,
171 file_path_for_history_item); 172 file_path_for_history_item);
172 173
174 OnDidAssignPageId(page_id);
173 FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), params); 175 FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), params);
174 OnDidCommitProvisionalLoad(msg); 176 OnDidCommitProvisionalLoad(msg);
175 } 177 }
176 178
177 void TestRenderFrameHost::SendBeginNavigationWithURL(const GURL& url) { 179 void TestRenderFrameHost::SendBeginNavigationWithURL(const GURL& url) {
178 FrameHostMsg_BeginNavigation_Params begin_params; 180 FrameHostMsg_BeginNavigation_Params begin_params;
179 CommonNavigationParams common_params; 181 CommonNavigationParams common_params;
180 begin_params.method = "GET"; 182 begin_params.method = "GET";
181 begin_params.load_flags = net::LOAD_NORMAL; 183 begin_params.load_flags = net::LOAD_NORMAL;
182 begin_params.has_user_gesture = false; 184 begin_params.has_user_gesture = false;
183 common_params.url = url; 185 common_params.url = url;
184 common_params.referrer = Referrer(GURL(), blink::WebReferrerPolicyDefault); 186 common_params.referrer = Referrer(GURL(), blink::WebReferrerPolicyDefault);
185 common_params.transition = ui::PAGE_TRANSITION_LINK; 187 common_params.transition = ui::PAGE_TRANSITION_LINK;
186 OnBeginNavigation(begin_params, common_params); 188 OnBeginNavigation(begin_params, common_params);
187 } 189 }
188 190
189 void TestRenderFrameHost::DidDisownOpener() { 191 void TestRenderFrameHost::DidDisownOpener() {
190 OnDidDisownOpener(); 192 OnDidDisownOpener();
191 } 193 }
192 194
193 } // namespace content 195 } // namespace content
OLDNEW
« no previous file with comments | « content/test/test_render_frame_host.h ('k') | content/test/test_render_view_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698