Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: content/test/test_render_frame_host.cc

Issue 556703004: Remove page id from FrameNavigateParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleaner Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/test_render_frame_host.cc
diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc
index e930c526e8bbe35b22b134ea7422ff33d2d53ab3..f54ee6231adfef6c72dbf19da14f175dd2cd6fa4 100644
--- a/content/test/test_render_frame_host.cc
+++ b/content/test/test_render_frame_host.cc
@@ -109,7 +109,9 @@ void TestRenderFrameHost::SendNavigateWithFile(
}
void TestRenderFrameHost::SendNavigateWithParams(
+ int page_id,
FrameHostMsg_DidCommitProvisionalLoad_Params* params) {
+ OnDidAssignPageId(page_id);
FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), *params);
OnDidCommitProvisionalLoad(msg);
}
@@ -131,7 +133,6 @@ void TestRenderFrameHost::SendNavigateWithParameters(
const base::FilePath* file_path_for_history_item,
const std::vector<GURL>& redirects) {
FrameHostMsg_DidCommitProvisionalLoad_Params params;
- params.page_id = page_id;
params.url = url;
params.referrer = Referrer();
params.transition = transition;
@@ -162,6 +163,7 @@ void TestRenderFrameHost::SendNavigateWithParameters(
file_path_for_history_item ? "data" : NULL,
file_path_for_history_item);
+ OnDidAssignPageId(page_id);
FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), params);
OnDidCommitProvisionalLoad(msg);
}

Powered by Google App Engine
This is Rietveld 408576698