Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Side by Side Diff: content/test/test_render_frame_host.cc

Issue 556703004: Remove page id from FrameNavigateParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleaner Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/test/test_render_frame_host.h" 5 #include "content/test/test_render_frame_host.h"
6 6
7 #include "content/browser/frame_host/frame_tree.h" 7 #include "content/browser/frame_host/frame_tree.h"
8 #include "content/browser/frame_host/render_frame_host_delegate.h" 8 #include "content/browser/frame_host/render_frame_host_delegate.h"
9 #include "content/common/frame_messages.h" 9 #include "content/common/frame_messages.h"
10 #include "content/public/common/page_transition_types.h" 10 #include "content/public/common/page_transition_types.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 102
103 void TestRenderFrameHost::SendNavigateWithFile( 103 void TestRenderFrameHost::SendNavigateWithFile(
104 int page_id, 104 int page_id,
105 const GURL& url, 105 const GURL& url,
106 const base::FilePath& file_path) { 106 const base::FilePath& file_path) {
107 SendNavigateWithParameters(page_id, url, PAGE_TRANSITION_LINK, url, 200, 107 SendNavigateWithParameters(page_id, url, PAGE_TRANSITION_LINK, url, 200,
108 &file_path, std::vector<GURL>()); 108 &file_path, std::vector<GURL>());
109 } 109 }
110 110
111 void TestRenderFrameHost::SendNavigateWithParams( 111 void TestRenderFrameHost::SendNavigateWithParams(
112 int page_id,
112 FrameHostMsg_DidCommitProvisionalLoad_Params* params) { 113 FrameHostMsg_DidCommitProvisionalLoad_Params* params) {
114 OnDidAssignPageId(page_id);
113 FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), *params); 115 FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), *params);
114 OnDidCommitProvisionalLoad(msg); 116 OnDidCommitProvisionalLoad(msg);
115 } 117 }
116 118
117 void TestRenderFrameHost::SendNavigateWithRedirects( 119 void TestRenderFrameHost::SendNavigateWithRedirects(
118 int page_id, 120 int page_id,
119 const GURL& url, 121 const GURL& url,
120 const std::vector<GURL>& redirects) { 122 const std::vector<GURL>& redirects) {
121 SendNavigateWithParameters( 123 SendNavigateWithParameters(
122 page_id, url, PAGE_TRANSITION_LINK, url, 200, 0, redirects); 124 page_id, url, PAGE_TRANSITION_LINK, url, 200, 0, redirects);
123 } 125 }
124 126
125 void TestRenderFrameHost::SendNavigateWithParameters( 127 void TestRenderFrameHost::SendNavigateWithParameters(
126 int page_id, 128 int page_id,
127 const GURL& url, 129 const GURL& url,
128 PageTransition transition, 130 PageTransition transition,
129 const GURL& original_request_url, 131 const GURL& original_request_url,
130 int response_code, 132 int response_code,
131 const base::FilePath* file_path_for_history_item, 133 const base::FilePath* file_path_for_history_item,
132 const std::vector<GURL>& redirects) { 134 const std::vector<GURL>& redirects) {
133 FrameHostMsg_DidCommitProvisionalLoad_Params params; 135 FrameHostMsg_DidCommitProvisionalLoad_Params params;
134 params.page_id = page_id;
135 params.url = url; 136 params.url = url;
136 params.referrer = Referrer(); 137 params.referrer = Referrer();
137 params.transition = transition; 138 params.transition = transition;
138 params.redirects = redirects; 139 params.redirects = redirects;
139 params.should_update_history = true; 140 params.should_update_history = true;
140 params.searchable_form_url = GURL(); 141 params.searchable_form_url = GURL();
141 params.searchable_form_encoding = std::string(); 142 params.searchable_form_encoding = std::string();
142 params.security_info = std::string(); 143 params.security_info = std::string();
143 params.gesture = NavigationGestureUser; 144 params.gesture = NavigationGestureUser;
144 params.contents_mime_type = contents_mime_type_; 145 params.contents_mime_type = contents_mime_type_;
(...skipping 10 matching lines...) Expand all
155 transition != PAGE_TRANSITION_TYPED && 156 transition != PAGE_TRANSITION_TYPED &&
156 url.ReplaceComponents(replacements) == 157 url.ReplaceComponents(replacements) ==
157 GetLastCommittedURL().ReplaceComponents(replacements); 158 GetLastCommittedURL().ReplaceComponents(replacements);
158 159
159 params.page_state = PageState::CreateForTesting( 160 params.page_state = PageState::CreateForTesting(
160 url, 161 url,
161 false, 162 false,
162 file_path_for_history_item ? "data" : NULL, 163 file_path_for_history_item ? "data" : NULL,
163 file_path_for_history_item); 164 file_path_for_history_item);
164 165
166 OnDidAssignPageId(page_id);
165 FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), params); 167 FrameHostMsg_DidCommitProvisionalLoad msg(GetRoutingID(), params);
166 OnDidCommitProvisionalLoad(msg); 168 OnDidCommitProvisionalLoad(msg);
167 } 169 }
168 170
169 void TestRenderFrameHost::SendBeginNavigationWithURL(const GURL& url) { 171 void TestRenderFrameHost::SendBeginNavigationWithURL(const GURL& url) {
170 FrameHostMsg_BeginNavigation_Params params; 172 FrameHostMsg_BeginNavigation_Params params;
171 params.method = "GET"; 173 params.method = "GET";
172 params.url = url; 174 params.url = url;
173 params.referrer = Referrer(GURL(), blink::WebReferrerPolicyDefault); 175 params.referrer = Referrer(GURL(), blink::WebReferrerPolicyDefault);
174 params.load_flags = net::LOAD_NORMAL; 176 params.load_flags = net::LOAD_NORMAL;
175 params.has_user_gesture = false; 177 params.has_user_gesture = false;
176 params.transition_type = PAGE_TRANSITION_LINK; 178 params.transition_type = PAGE_TRANSITION_LINK;
177 params.should_replace_current_entry = false; 179 params.should_replace_current_entry = false;
178 params.allow_download = true; 180 params.allow_download = true;
179 OnBeginNavigation(params); 181 OnBeginNavigation(params);
180 } 182 }
181 183
182 void TestRenderFrameHost::DidDisownOpener() { 184 void TestRenderFrameHost::DidDisownOpener() {
183 OnDidDisownOpener(); 185 OnDidDisownOpener();
184 } 186 }
185 187
186 } // namespace content 188 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698