Issue 556563005: Fix Smi vs. HeapObject confusion in HConstants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 556563005: Fix Smi vs. HeapObject confusion in HConstants. (Closed)

Created:
6 years, 3 months ago by Jakob Kummerow

Modified:
6 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Fix Smi vs. HeapObject confusion in HConstants. Representation and HType should agree with each other. BUG=chromium:412215 LOG=y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23901

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -2 lines)			Patch
M	src/conversions.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/hydrogen-types.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-crbug-412215.js	View	1 chunk	+33 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

6 years, 3 months ago (2014-09-12 08:44:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23901 (presubmit successful).