src/hydrogen-instructions.h - Issue 556563005: Fix Smi vs. HeapObject confusion in HConstants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.h

Issue 556563005: Fix Smi vs. HeapObject confusion in HConstants. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-instructions.h

diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h

index 1844715dbdf91c7257f964cffd1622b6ab2e9484..1c32400e24b16ec0991cc2235c3e0c50de65ce43 100644

--- a/src/hydrogen-instructions.h

+++ b/src/hydrogen-instructions.h

@@ -3493,7 +3493,7 @@ class HConstant FINAL : public HTemplateInstruction<0> {

virtual Handle<Map> GetMonomorphicJSObjectMap() OVERRIDE {

Handle<Object> object = object_.handle();

- if (object->IsHeapObject()) {

+ if (!object.is_null() && object->IsHeapObject()) {

return v8::internal::handle(HeapObject::cast(*object)->map());

}

return Handle<Map>();

« no previous file with comments | « src/conversions.h ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »