Move ExtensionOptionsGuest code from chrome to extensions

Move ExtensionOptionsGuest code from chrome to extensions

Move embedded extension options guest view files from
chrome/browser/guest_view/extension_options/ to
extensions/browser/guest_view/extension_options. Also add a
ExtensionOptionsGuestDelegate in chrome/ to handle certain tasks, like
opening tabs and handling context menus, which cannot be run from
within extensions/.

This move makes the extension_options codebase more consistent with the
other guest views, which are organized similarly.

BUG=409316
Committed: https://crrev.com/38c80c1b5a395a1890d8746aad8c3289a9ffde73
Cr-Commit-Position: refs/heads/master@{#294326}

[ericzeng, 2014-09-09 01:19:12]

ericzeng@chromium.org changed reviewers:
+ fsamuel@chromium.org, rdevlin.cronin@chromium.org, rockot@chromium.org,
yoz@chromium.org

[ericzeng, 2014-09-09 01:19:13]

PTAL

[Fady Samuel, 2014-09-09 02:15:39]

https://codereview.chromium.org/556563003/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/extension_options/extension_options_guest.cc
(right):

https://codereview.chromium.org/556563003/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/extension_options/extension_options_guest.cc:117:
if (extension_options_guest_delegate_)
Put the statement below in a block.

https://codereview.chromium.org/556563003/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/extension_options/extension_options_guest.cc:188:
return extension_options_guest_delegate_
Could you please use an if statement instead with early exit?

if (!extension_options_guest_delegate_)
  return false;

return extension_options_guest_delegate_->HandleContextMenu(...)

https://codereview.chromium.org/556563003/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/extension_options/extension_options_guest.cc:209:
if (extension_options_guest_delegate_) {
Early exit preferred for readability:

if (!extension_options_guest_delegate_)
  return false;

[ericzeng, 2014-09-09 20:31:32]

https://codereview.chromium.org/556563003/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/extension_options/extension_options_guest.cc
(right):

https://codereview.chromium.org/556563003/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/extension_options/extension_options_guest.cc:117:
if (extension_options_guest_delegate_)
On 2014/09/09 02:15:39, Fady Samuel wrote:
> Put the statement below in a block.

Done.

https://codereview.chromium.org/556563003/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/extension_options/extension_options_guest.cc:188:
return extension_options_guest_delegate_
On 2014/09/09 02:15:39, Fady Samuel wrote:
> Could you please use an if statement instead with early exit?
> 
> if (!extension_options_guest_delegate_)
>   return false;
> 
> return extension_options_guest_delegate_->HandleContextMenu(...)

Done.

https://codereview.chromium.org/556563003/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/extension_options/extension_options_guest.cc:209:
if (extension_options_guest_delegate_) {
On 2014/09/09 02:15:39, Fady Samuel wrote:
> Early exit preferred for readability:
> 
> if (!extension_options_guest_delegate_)
>   return false;

False is returned whether or not the extension_options_guest_delegate_ exists.

[Fady Samuel, 2014-09-09 20:57:36]

guest_view lgtm

[Ken Rockot(use gerrit already), 2014-09-09 21:02:12]

great. extensions lgtm

[Yoyo Zhou, 2014-09-09 22:22:36]

On 2014/09/09 21:02:12, Ken Rockot wrote:
> great. extensions lgtm

LGTM

[ericzeng, 2014-09-10 00:24:27]

The CQ bit was checked by ericzeng@chromium.org

[commit-bot: I haz the power, 2014-09-10 00:30:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ericzeng@chromium.org/556563003/40001

[commit-bot: I haz the power, 2014-09-10 01:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 01:49:35]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericzeng, 2014-09-10 07:41:08]

The CQ bit was checked by ericzeng@chromium.org

[commit-bot: I haz the power, 2014-09-10 07:41:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ericzeng@chromium.org/556563003/40001

[commit-bot: I haz the power, 2014-09-10 07:52:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 07:52:05]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2014-09-10 11:11:32]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-09-10 11:12:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ericzeng@chromium.org/556563003/40001

[commit-bot: I haz the power, 2014-09-10 11:20:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 11:20:47]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2014-09-10 11:21:57]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-09-10 11:22:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ericzeng@chromium.org/556563003/40001

[commit-bot: I haz the power, 2014-09-10 11:29:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 11:29:30]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericzeng, 2014-09-10 17:32:09]

The CQ bit was checked by ericzeng@chromium.org

[commit-bot: I haz the power, 2014-09-10 17:33:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ericzeng@chromium.org/556563003/60001

[commit-bot: I haz the power, 2014-09-10 18:09:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 18:09:43]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericzeng, 2014-09-10 20:57:03]

The CQ bit was checked by ericzeng@chromium.org

[commit-bot: I haz the power, 2014-09-10 21:01:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ericzeng@chromium.org/556563003/80001

[commit-bot: I haz the power, 2014-09-10 22:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 22:04:03]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericzeng, 2014-09-10 22:24:53]

The CQ bit was checked by ericzeng@chromium.org

[commit-bot: I haz the power, 2014-09-10 22:30:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/556563003/100001

[commit-bot: I haz the power, 2014-09-10 23:52:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 23:52:10]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ericzeng, 2014-09-11 00:20:25]

The CQ bit was checked by ericzeng@chromium.org

[commit-bot: I haz the power, 2014-09-11 00:21:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/556563003/120001

[commit-bot: I haz the power, 2014-09-11 01:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 01:18:35]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericzeng, 2014-09-11 02:48:35]

The CQ bit was checked by ericzeng@chromium.org

[commit-bot: I haz the power, 2014-09-11 02:49:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/556563003/140001

[commit-bot: I haz the power, 2014-09-11 05:44:00]

Committed patchset #8 (id:140001) as 4677827c5c4bb1304f07dc27acccd39ed764f070

[commit-bot: I haz the power, 2014-09-11 05:46:02]

Patchset 8 (id:??) landed as
https://crrev.com/38c80c1b5a395a1890d8746aad8c3289a9ffde73
Cr-Commit-Position: refs/heads/master@{#294326}