Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: extensions/browser/api/extensions_api_client.h

Issue 556563003: Move ExtensionOptionsGuest code from chrome to extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix gn Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/BUILD.gn ('k') | extensions/browser/api/extensions_api_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/extensions_api_client.h
diff --git a/extensions/browser/api/extensions_api_client.h b/extensions/browser/api/extensions_api_client.h
index 62f187ddb66ee4831f0523b249c4ff659f461112..77fb90970e342ac0ab18533216673978f8ebf600 100644
--- a/extensions/browser/api/extensions_api_client.h
+++ b/extensions/browser/api/extensions_api_client.h
@@ -24,6 +24,7 @@ class BrowserContext;
namespace extensions {
class AppViewGuestDelegate;
+class ExtensionOptionsGuestDelegate;
class MimeHandlerViewGuest;
class MimeHandlerViewGuestDelegate;
class WebViewGuest;
@@ -61,6 +62,11 @@ class ExtensionsAPIClient {
// Creates the AppViewGuestDelegate.
virtual AppViewGuestDelegate* CreateAppViewGuestDelegate() const;
+ // Returns a delegate for ExtensionOptionsGuest. The caller owns the returned
+ // ExtensionOptionsGuestDelegate.
+ virtual ExtensionOptionsGuestDelegate* CreateExtensionOptionsGuestDelegate()
+ const;
+
// Creates a delegate for MimeHandlerViewGuest.
virtual scoped_ptr<MimeHandlerViewGuestDelegate>
CreateMimeHandlerViewGuestDelegate(MimeHandlerViewGuest* guest) const;
@@ -76,8 +82,6 @@ class ExtensionsAPIClient {
CreateWebViewPermissionHelperDelegate (
WebViewPermissionHelper* web_view_permission_helper) const;
- virtual void RegisterGuestViewTypes() {}
-
// TODO(wjmaclean): Remove this as soon as rules_registry_service.* moves to
// extensions/browser/api/declarative/.
virtual scoped_refptr<RulesRegistry> GetRulesRegistry(
« no previous file with comments | « extensions/browser/BUILD.gn ('k') | extensions/browser/api/extensions_api_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698