Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 556363003: Print Preview UI tweaks (Closed)

Created:
6 years, 3 months ago by Aleksey Shlyapnikov
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Print Preview UI changes: - show 'More options' section only if there are more than 6 sections avaialble - add ARIA labels for the color, copies, margins, layout and paper settings - group Paper size section with other collapsible sections - adjust Advanced options button size to fit the text BUG=397741 Committed: https://crrev.com/4db543f3ebedb955c32b8a64a0993766079ddbde Cr-Commit-Position: refs/heads/master@{#294287}

Patch Set 1 #

Patch Set 2 : Adjust browser_tests accordingly. #

Messages

Total messages: 11 (4 generated)
Aleksey Shlyapnikov
6 years, 3 months ago (2014-09-10 18:45:30 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-09-10 20:06:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/556363003/1
6 years, 3 months ago (2014-09-10 20:17:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/12880) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/14947)
6 years, 3 months ago (2014-09-10 21:51:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556363003/20001
6 years, 3 months ago (2014-09-10 23:49:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 06aadc6bd3a7d44bd288f85c70c021c1356dcebf
6 years, 3 months ago (2014-09-11 01:41:54 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 02:00:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4db543f3ebedb955c32b8a64a0993766079ddbde
Cr-Commit-Position: refs/heads/master@{#294287}

Powered by Google App Engine
This is Rietveld 408576698