chrome/browser/resources/print_preview/settings/margin_settings.html - Issue 556363003: Print Preview UI tweaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/margin_settings.html

Issue 556363003: Print Preview UI tweaks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust browser_tests accordingly. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/settings/layout_settings.html ('k') | chrome/browser/resources/print_preview/settings/media_size_settings.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/margin_settings.html

diff --git a/chrome/browser/resources/print_preview/settings/margin_settings.html b/chrome/browser/resources/print_preview/settings/margin_settings.html

index 0d6eed0a523657d1b08537ad95424217b912e25a..2310203237ead259248a15f381d2e0d4055a34b2 100644

--- a/chrome/browser/resources/print_preview/settings/margin_settings.html

+++ b/chrome/browser/resources/print_preview/settings/margin_settings.html

@@ -1,7 +1,7 @@

- <h1 i18n-content="marginsLabel"></h1>

+ <h1 id="margin-label" i18n-content="marginsLabel"></h1>

- <select class="margin-settings-select">

+ <select class="margin-settings-select" aria-labelledby="margin-label">

<!-- The order of these options must match the natural order of their

values, which come from print_preview.ticket_items.MarginsType.Value. -->