In generated dictionary toImpl(), throw all exceptions via ExceptionState

In generated dictionary toImpl(), throw all exceptions via ExceptionState

This allows us to simplify callers by not having a v8::TryCatch there, and
instead only check the ExceptionState object.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181738

[Jens Widell, 2014-09-10 14:09:00]

jl@opera.com changed reviewers:
+ bashi@google.com, haraken@chromium.org

[Jens Widell, 2014-09-10 14:09:01]

PTAL

A temporary fix while we still use DictionaryHelper in this code. Makes it
possible to land https://codereview.chromium.org/552143004/.

[bashi, 2014-09-10 14:12:51]

bashi@chromium.org changed reviewers:
+ bashi@chromium.org

[bashi, 2014-09-10 14:12:51]

LGTM. Thank you for working on this!

https://codereview.chromium.org/556273003/diff/1/Source/bindings/templates/di...
File Source/bindings/templates/dictionary_v8.cpp (right):

https://codereview.chromium.org/556273003/diff/1/Source/bindings/templates/di...
Source/bindings/templates/dictionary_v8.cpp:22: v8::TryCatch block;
Could you leave a FIXME comment so that I won't miss removing this?

[Jens Widell, 2014-09-10 14:26:46]

Thanks for quick review!

https://codereview.chromium.org/556273003/diff/1/Source/bindings/templates/di...
File Source/bindings/templates/dictionary_v8.cpp (right):

https://codereview.chromium.org/556273003/diff/1/Source/bindings/templates/di...
Source/bindings/templates/dictionary_v8.cpp:22: v8::TryCatch block;
On 2014/09/10 14:12:51, bashi1 wrote:
> Could you leave a FIXME comment so that I won't miss removing this?

Done.

[haraken, 2014-09-10 15:38:50]

LGTM

[Jens Widell, 2014-09-10 15:41:40]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-09-10 15:42:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/556273003/20001

[commit-bot: I haz the power, 2014-09-10 15:47:38]

Committed patchset #2 (id:20001) as 181738