Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Side by Side Diff: Source/bindings/tests/results/core/V8TestDictionary.cpp

Issue 556273003: In generated dictionary toImpl(), throw all exceptions via ExceptionState (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: added FIXME comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/templates/dictionary_v8.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "V8TestDictionary.h" 8 #include "V8TestDictionary.h"
9 9
10 #include "bindings/core/v8/Dictionary.h" 10 #include "bindings/core/v8/Dictionary.h"
11 #include "bindings/core/v8/ExceptionState.h" 11 #include "bindings/core/v8/ExceptionState.h"
12 #include "bindings/tests/v8/V8TestInterface.h" 12 #include "bindings/tests/v8/V8TestInterface.h"
13 #include "bindings/tests/v8/V8TestInterfaceGarbageCollected.h" 13 #include "bindings/tests/v8/V8TestInterfaceGarbageCollected.h"
14 #include "bindings/tests/v8/V8TestInterfaceWillBeGarbageCollected.h" 14 #include "bindings/tests/v8/V8TestInterfaceWillBeGarbageCollected.h"
15 15
16 namespace blink { 16 namespace blink {
17 17
18 TestDictionary* V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Handle<v8::Va lue> v8Value, ExceptionState& exceptionState) 18 TestDictionary* V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Handle<v8::Va lue> v8Value, ExceptionState& exceptionState)
19 { 19 {
20 TestDictionary* impl = TestDictionary::create(); 20 TestDictionary* impl = TestDictionary::create();
21 // FIXME: Do not use Dictionary and DictionaryHelper 21 // FIXME: Do not use Dictionary and DictionaryHelper
22 // https://crbug.com/321462 22 // https://crbug.com/321462
23 Dictionary dictionary(v8Value, isolate); 23 Dictionary dictionary(v8Value, isolate);
24 // FIXME: Remove this v8::TryCatch once the code is switched from
25 // Dictionary/DictionaryHelper to something that uses ExceptionState.
26 v8::TryCatch block;
24 bool booleanMember; 27 bool booleanMember;
25 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "booleanMember ", booleanMember)) { 28 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "booleanMember ", booleanMember)) {
26 impl->setBooleanMember(booleanMember); 29 impl->setBooleanMember(booleanMember);
30 } else if (block.HasCaught()) {
31 exceptionState.rethrowV8Exception(block.Exception());
32 return 0;
27 } 33 }
28 double doubleOrNullMember; 34 double doubleOrNullMember;
29 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "doubleOrNullM ember", doubleOrNullMember)) { 35 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "doubleOrNullM ember", doubleOrNullMember)) {
30 impl->setDoubleOrNullMember(doubleOrNullMember); 36 impl->setDoubleOrNullMember(doubleOrNullMember);
37 } else if (block.HasCaught()) {
38 exceptionState.rethrowV8Exception(block.Exception());
39 return 0;
31 } 40 }
32 String enumMember; 41 String enumMember;
33 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "enumMember", enumMember)) { 42 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "enumMember", enumMember)) {
34 String string = enumMember; 43 String string = enumMember;
35 if (!(string == "foo" || string == "bar" || string == "baz")) { 44 if (!(string == "foo" || string == "bar" || string == "baz")) {
36 exceptionState.throwTypeError("member enumMember ('" + string + "') is not a valid enum value."); 45 exceptionState.throwTypeError("member enumMember ('" + string + "') is not a valid enum value.");
37 return 0; 46 return 0;
38 } 47 }
39 impl->setEnumMember(enumMember); 48 impl->setEnumMember(enumMember);
49 } else if (block.HasCaught()) {
50 exceptionState.rethrowV8Exception(block.Exception());
51 return 0;
40 } 52 }
41 int longMember; 53 int longMember;
42 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "longMember", longMember)) { 54 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "longMember", longMember)) {
43 impl->setLongMember(longMember); 55 impl->setLongMember(longMember);
56 } else if (block.HasCaught()) {
57 exceptionState.rethrowV8Exception(block.Exception());
58 return 0;
44 } 59 }
45 Vector<String> stringArrayMember; 60 Vector<String> stringArrayMember;
46 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "stringArrayMe mber", stringArrayMember)) { 61 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "stringArrayMe mber", stringArrayMember)) {
47 impl->setStringArrayMember(stringArrayMember); 62 impl->setStringArrayMember(stringArrayMember);
63 } else if (block.HasCaught()) {
64 exceptionState.rethrowV8Exception(block.Exception());
65 return 0;
48 } 66 }
49 String stringMember; 67 String stringMember;
50 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "stringMember" , stringMember)) { 68 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "stringMember" , stringMember)) {
51 impl->setStringMember(stringMember); 69 impl->setStringMember(stringMember);
70 } else if (block.HasCaught()) {
71 exceptionState.rethrowV8Exception(block.Exception());
72 return 0;
52 } 73 }
53 String stringOrNullMember; 74 String stringOrNullMember;
54 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "stringOrNullM ember", stringOrNullMember)) { 75 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "stringOrNullM ember", stringOrNullMember)) {
55 impl->setStringOrNullMember(stringOrNullMember); 76 impl->setStringOrNullMember(stringOrNullMember);
77 } else if (block.HasCaught()) {
78 exceptionState.rethrowV8Exception(block.Exception());
79 return 0;
56 } 80 }
57 Vector<String> stringSequenceMember; 81 Vector<String> stringSequenceMember;
58 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "stringSequenc eMember", stringSequenceMember)) { 82 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "stringSequenc eMember", stringSequenceMember)) {
59 impl->setStringSequenceMember(stringSequenceMember); 83 impl->setStringSequenceMember(stringSequenceMember);
84 } else if (block.HasCaught()) {
85 exceptionState.rethrowV8Exception(block.Exception());
86 return 0;
60 } 87 }
61 RawPtr<TestInterfaceGarbageCollected> testInterfaceGarbageCollectedMember; 88 RawPtr<TestInterfaceGarbageCollected> testInterfaceGarbageCollectedMember;
62 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface GarbageCollectedMember", testInterfaceGarbageCollectedMember)) { 89 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface GarbageCollectedMember", testInterfaceGarbageCollectedMember)) {
63 impl->setTestInterfaceGarbageCollectedMember(testInterfaceGarbageCollect edMember); 90 impl->setTestInterfaceGarbageCollectedMember(testInterfaceGarbageCollect edMember);
91 } else if (block.HasCaught()) {
92 exceptionState.rethrowV8Exception(block.Exception());
93 return 0;
64 } 94 }
65 RawPtr<TestInterfaceGarbageCollected> testInterfaceGarbageCollectedOrNullMem ber; 95 RawPtr<TestInterfaceGarbageCollected> testInterfaceGarbageCollectedOrNullMem ber;
66 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface GarbageCollectedOrNullMember", testInterfaceGarbageCollectedOrNullMember)) { 96 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface GarbageCollectedOrNullMember", testInterfaceGarbageCollectedOrNullMember)) {
67 impl->setTestInterfaceGarbageCollectedOrNullMember(testInterfaceGarbageC ollectedOrNullMember); 97 impl->setTestInterfaceGarbageCollectedOrNullMember(testInterfaceGarbageC ollectedOrNullMember);
98 } else if (block.HasCaught()) {
99 exceptionState.rethrowV8Exception(block.Exception());
100 return 0;
68 } 101 }
69 RefPtr<TestInterfaceImplementation> testInterfaceMember; 102 RefPtr<TestInterfaceImplementation> testInterfaceMember;
70 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface Member", testInterfaceMember)) { 103 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface Member", testInterfaceMember)) {
71 impl->setTestInterfaceMember(testInterfaceMember); 104 impl->setTestInterfaceMember(testInterfaceMember);
105 } else if (block.HasCaught()) {
106 exceptionState.rethrowV8Exception(block.Exception());
107 return 0;
72 } 108 }
73 RefPtr<TestInterfaceImplementation> testInterfaceOrNullMember; 109 RefPtr<TestInterfaceImplementation> testInterfaceOrNullMember;
74 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface OrNullMember", testInterfaceOrNullMember)) { 110 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface OrNullMember", testInterfaceOrNullMember)) {
75 impl->setTestInterfaceOrNullMember(testInterfaceOrNullMember); 111 impl->setTestInterfaceOrNullMember(testInterfaceOrNullMember);
112 } else if (block.HasCaught()) {
113 exceptionState.rethrowV8Exception(block.Exception());
114 return 0;
76 } 115 }
77 RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> testInterfaceWillBeG arbageCollectedMember; 116 RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> testInterfaceWillBeG arbageCollectedMember;
78 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface WillBeGarbageCollectedMember", testInterfaceWillBeGarbageCollectedMember)) { 117 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface WillBeGarbageCollectedMember", testInterfaceWillBeGarbageCollectedMember)) {
79 impl->setTestInterfaceWillBeGarbageCollectedMember(testInterfaceWillBeGa rbageCollectedMember); 118 impl->setTestInterfaceWillBeGarbageCollectedMember(testInterfaceWillBeGa rbageCollectedMember);
119 } else if (block.HasCaught()) {
120 exceptionState.rethrowV8Exception(block.Exception());
121 return 0;
80 } 122 }
81 RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> testInterfaceWillBeG arbageCollectedOrNullMember; 123 RefPtrWillBeRawPtr<TestInterfaceWillBeGarbageCollected> testInterfaceWillBeG arbageCollectedOrNullMember;
82 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface WillBeGarbageCollectedOrNullMember", testInterfaceWillBeGarbageCollectedOrNullMe mber)) { 124 if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "testInterface WillBeGarbageCollectedOrNullMember", testInterfaceWillBeGarbageCollectedOrNullMe mber)) {
83 impl->setTestInterfaceWillBeGarbageCollectedOrNullMember(testInterfaceWi llBeGarbageCollectedOrNullMember); 125 impl->setTestInterfaceWillBeGarbageCollectedOrNullMember(testInterfaceWi llBeGarbageCollectedOrNullMember);
126 } else if (block.HasCaught()) {
127 exceptionState.rethrowV8Exception(block.Exception());
128 return 0;
84 } 129 }
85 return impl; 130 return impl;
86 } 131 }
87 132
88 v8::Handle<v8::Value> toV8(TestDictionary* impl, v8::Handle<v8::Object> creation Context, v8::Isolate* isolate) 133 v8::Handle<v8::Value> toV8(TestDictionary* impl, v8::Handle<v8::Object> creation Context, v8::Isolate* isolate)
89 { 134 {
90 v8::Handle<v8::Object> v8Object = v8::Object::New(isolate); 135 v8::Handle<v8::Object> v8Object = v8::Object::New(isolate);
91 if (impl->hasBooleanMember()) 136 if (impl->hasBooleanMember())
92 v8Object->Set(v8String(isolate, "booleanMember"), v8Boolean(impl->boolea nMember(), isolate)); 137 v8Object->Set(v8String(isolate, "booleanMember"), v8Boolean(impl->boolea nMember(), isolate));
93 if (impl->hasDoubleOrNullMember()) 138 if (impl->hasDoubleOrNullMember())
(...skipping 27 matching lines...) Expand all
121 if (impl->hasTestInterfaceOrNullMember()) 166 if (impl->hasTestInterfaceOrNullMember())
122 v8Object->Set(v8String(isolate, "testInterfaceOrNullMember"), toV8(impl- >testInterfaceOrNullMember(), creationContext, isolate)); 167 v8Object->Set(v8String(isolate, "testInterfaceOrNullMember"), toV8(impl- >testInterfaceOrNullMember(), creationContext, isolate));
123 if (impl->hasTestInterfaceWillBeGarbageCollectedMember()) 168 if (impl->hasTestInterfaceWillBeGarbageCollectedMember())
124 v8Object->Set(v8String(isolate, "testInterfaceWillBeGarbageCollectedMemb er"), toV8(impl->testInterfaceWillBeGarbageCollectedMember(), creationContext, i solate)); 169 v8Object->Set(v8String(isolate, "testInterfaceWillBeGarbageCollectedMemb er"), toV8(impl->testInterfaceWillBeGarbageCollectedMember(), creationContext, i solate));
125 if (impl->hasTestInterfaceWillBeGarbageCollectedOrNullMember()) 170 if (impl->hasTestInterfaceWillBeGarbageCollectedOrNullMember())
126 v8Object->Set(v8String(isolate, "testInterfaceWillBeGarbageCollectedOrNu llMember"), toV8(impl->testInterfaceWillBeGarbageCollectedOrNullMember(), creati onContext, isolate)); 171 v8Object->Set(v8String(isolate, "testInterfaceWillBeGarbageCollectedOrNu llMember"), toV8(impl->testInterfaceWillBeGarbageCollectedOrNullMember(), creati onContext, isolate));
127 return v8Object; 172 return v8Object;
128 } 173 }
129 174
130 } // namespace blink 175 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/templates/dictionary_v8.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698