Issue 556103002: Simplify QuicUnackedPacketMap's RemovePreviousTransmissions by always

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 556103002: Simplify QuicUnackedPacketMap's RemovePreviousTransmissions by always (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)

Modified:
6 years, 3 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@discard_old_packets_74814618

Project:
chromium

Visibility:
Public.

More Reviews

Description

Simplify QuicUnackedPacketMap's RemovePreviousTransmissions by always removing all old transmissions. When truncated acks start arriving, they don't stop until least_unacked is raised, which takes an entire RTT, so this is the eventual effect of all those truncated acks. Instead, remove all of them the first time. Merge internal change: 74881713 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -10 lines)			Patch
M	net/quic/quic_sent_packet_manager.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/quic/quic_unacked_packet_map.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/quic/quic_unacked_packet_map.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	net/quic/quic_unacked_packet_map_test.cc	View	1 chunk	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages