net/quic/quic_sent_packet_manager.cc - Issue 556103002: Simplify QuicUnackedPacketMap's RemovePreviousTransmissions by always

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 556103002: Simplify QuicUnackedPacketMap's RemovePreviousTransmissions by always (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@discard_old_packets_74814618

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_sent_packet_manager.cc

diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc

index a5b1a9d4b71eb2f9525fa0e5c84e7e127f7634fd..e0f49377f4cab2df5fb761b812385eb792679064 100644

--- a/net/quic/quic_sent_packet_manager.cc

+++ b/net/quic/quic_sent_packet_manager.cc

@@ -210,8 +210,7 @@ void QuicSentPacketManager::OnIncomingAck(const QuicAckFrame& ack_frame,

// If we have received a truncated ack, then we need to clear out some

// previous transmissions to allow the peer to actually ACK new packets.

if (ack_frame.is_truncated) {

- unacked_packets_.ClearPreviousRetransmissions(

- ack_frame.missing_packets.size() / 2);

+ unacked_packets_.ClearAllPreviousRetransmissions();

}

// Anytime we are making forward progress and have a new RTT estimate, reset

« no previous file with comments | « no previous file | net/quic/quic_unacked_packet_map.h » ('j') | no next file with comments »