athena: Change the scrolling behaviour of the windows in overview mode.

athena: Change the scrolling behaviour of the windows in overview mode.

Change the transforms of the windows in overview mode to better match the mocks.
Notable change in the code is that instead of computing the terminal transforms
at the start, and then computing the intermediate transforms from those, we
compute less amount of information at start, and compute the transform at each
state from those. This makes it easier to perform non-linear transforms during
the scrolls.

BUG=403849
R=oshima@chromium.org

Committed: https://crrev.com/4bf71ed7540d1ead878e1891d6e819789863bf60
Cr-Commit-Position: refs/heads/master@{#294108}

[sadrul, 2014-09-09 22:03:13]

sadrul@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2014-09-10 00:19:42]

lgtm with nits

https://codereview.chromium.org/556043002/diff/1/athena/wm/window_overview_mo...
File athena/wm/window_overview_mode.cc (right):

https://codereview.chromium.org/556043002/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:43: float min_y;
please document them.

https://codereview.chromium.org/556043002/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:61: transform.Translate(x_translate,
window->bounds().height() * 0.65);
define const for 0.65

https://codereview.chromium.org/556043002/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:72: const float kStartShrinking = 0.07;
kProgressToStartShrinking ?

https://codereview.chromium.org/556043002/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:76: const float kShrunkScale = 0.7f;
kShrunkMinimumScale ?

[sadrul, 2014-09-10 04:38:40]

https://codereview.chromium.org/556043002/diff/1/athena/wm/window_overview_mo...
File athena/wm/window_overview_mode.cc (right):

https://codereview.chromium.org/556043002/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:43: float min_y;
On 2014/09/10 00:19:42, oshima wrote:
> please document them.

Done.

https://codereview.chromium.org/556043002/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:61: transform.Translate(x_translate,
window->bounds().height() * 0.65);
On 2014/09/10 00:19:42, oshima wrote:
> define const for 0.65 

Done.

https://codereview.chromium.org/556043002/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:72: const float kStartShrinking = 0.07;
On 2014/09/10 00:19:42, oshima wrote:
> kProgressToStartShrinking ?

Done.

https://codereview.chromium.org/556043002/diff/1/athena/wm/window_overview_mo...
athena/wm/window_overview_mode.cc:76: const float kShrunkScale = 0.7f;
On 2014/09/10 00:19:42, oshima wrote:
> kShrunkMinimumScale ?

Done.

[sadrul, 2014-09-10 05:18:07]

Committed patchset #2 (id:20001) to pending queue manually as f85c940 (presubmit
successful).

[commit-bot: I haz the power, 2014-09-10 05:24:03]

Patchset 2 (id:??) landed as
https://crrev.com/4bf71ed7540d1ead878e1891d6e819789863bf60
Cr-Commit-Position: refs/heads/master@{#294108}