content/browser/service_worker/service_worker_registration.h - Issue 556003006: [ServiceWorker] Check is_uninstalled in ServiceWorkerRegisterJob::ContinueWithRegistration()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.h

Issue 556003006: [ServiceWorker] Check is_uninstalled in ServiceWorkerRegisterJob::ContinueWithRegistration() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_registration.cc » ('j') | content/browser/service_worker/service_worker_registration.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration.h

diff --git a/content/browser/service_worker/service_worker_registration.h b/content/browser/service_worker/service_worker_registration.h

index caa98a2cc8f0c8d909ad33699beff7a90ce4f543..bf220d35ad69e9e52ad115e1267bf7e2b41187fa 100644

--- a/content/browser/service_worker/service_worker_registration.h

+++ b/content/browser/service_worker/service_worker_registration.h

@@ -54,6 +54,7 @@ class CONTENT_EXPORT ServiceWorkerRegistration

void set_is_deleted(bool deleted) { is_deleted_ = deleted; }

bool is_uninstalling() const { return is_uninstalling_; }

+ bool is_uninstalled() const { return is_uninstalled_; }

ServiceWorkerVersion* active_version() const {

return active_version_.get();

@@ -140,6 +141,7 @@ class CONTENT_EXPORT ServiceWorkerRegistration

const int64 registration_id_;

bool is_deleted_;

nhiroki 2014/09/11 13:05:38 I wonder if we can use |is_deleted| for this purpo

horo 2014/09/11 17:50:14 No we can't. is_deleted_ flag is set when the del

bool is_uninstalling_;

+ bool is_uninstalled_;

bool should_activate_when_ready_;

base::Time last_update_check_;

scoped_refptr<ServiceWorkerVersion> active_version_;