[ServiceWorker] Check is_uninstalled in ServiceWorkerRegisterJob::ContinueWithRegistration()

content/browser/service_worker/service_worker_registration.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/logging.h"
@@ skipping 36 matching lines @@
                             int64 registration_id,
                             base::WeakPtr<ServiceWorkerContextCore> context);
 
   int64 id() const { return registration_id_; }
   const GURL& pattern() const { return pattern_; }
 
   bool is_deleted() const { return is_deleted_; }
   void set_is_deleted(bool deleted) { is_deleted_ = deleted; }
 
   bool is_uninstalling() const { return is_uninstalling_; }
+  bool is_uninstalled() const { return is_uninstalled_; }
 
   ServiceWorkerVersion* active_version() const {
     return active_version_.get();
   }
 
   ServiceWorkerVersion* waiting_version() const {
     return waiting_version_.get();
   }
 
   ServiceWorkerVersion* installing_version() const {
@@ skipping 64 matching lines @@
 
   // This method corresponds to the [[ClearRegistration]] algorithm.
   void Clear();
 
   void OnRestoreFinished(const StatusCallback& callback,
                          scoped_refptr<ServiceWorkerVersion> version,
                          ServiceWorkerStatusCode status);
 
   const GURL pattern_;
   const int64 registration_id_;
   bool is_deleted_;

[nhiroki, 2014/09/11 13:05:38]

I wonder if we can use |is_deleted| for this purpose. WDYT?

[horo, 2014/09/11 17:50:14]

No we can't.

is_deleted_ flag is set when the deletion of the records from the db is started.
is_uninstalled_ flag is set when the all controlled pages are closed.

[[Register]] must wait until this uninstall process.
So we have to check is_uninstalled_.

https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#register-alg...

   bool is_uninstalling_;
+  bool is_uninstalled_;
   bool should_activate_when_ready_;
   base::Time last_update_check_;
   scoped_refptr<ServiceWorkerVersion> active_version_;
   scoped_refptr<ServiceWorkerVersion> waiting_version_;
   scoped_refptr<ServiceWorkerVersion> installing_version_;
   ObserverList<Listener> listeners_;
   base::WeakPtr<ServiceWorkerContextCore> context_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerRegistration);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_