Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: content/browser/service_worker/service_worker_registration.cc

Issue 556003006: [ServiceWorker] Check is_uninstalled in ServiceWorkerRegisterJob::ContinueWithRegistration() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration.cc
diff --git a/content/browser/service_worker/service_worker_registration.cc b/content/browser/service_worker/service_worker_registration.cc
index 33fdfa6767fee298fafa53e31041cca2d786cf80..ba3298cea61129e982a1aa9914e674f22ae01813 100644
--- a/content/browser/service_worker/service_worker_registration.cc
+++ b/content/browser/service_worker/service_worker_registration.cc
@@ -30,6 +30,7 @@ ServiceWorkerRegistration::ServiceWorkerRegistration(
registration_id_(registration_id),
is_deleted_(false),
is_uninstalling_(false),
+ is_uninstalled_(false),
should_activate_when_ready_(false),
context_(context) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
@@ -315,6 +316,7 @@ void ServiceWorkerRegistration::Clear() {
FOR_EACH_OBSERVER(
Listener, listeners_, OnRegistrationFinishedUninstalling(this));
+ is_uninstalled_ = true;
michaeln 2014/09/11 19:31:40 Would it make sense to set this flag immediately a
horo 2014/09/12 01:09:25 That's make sense. Done. Thank you.
}
void ServiceWorkerRegistration::OnRestoreFinished(

Powered by Google App Engine
This is Rietveld 408576698