Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 555843003: Remove PageSet.FromFile method since it's no longer used. (Closed)

Created:
6 years, 3 months ago by nednguyen
Modified:
6 years, 3 months ago
Reviewers:
ariblue, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove PageSet.FromFile method since it's no longer used. BUG= Committed: https://crrev.com/b188e83b9b316708b39381c64f46fb8ea25fdb30 Cr-Commit-Position: refs/heads/master@{#294069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -73 lines) Patch
M tools/telemetry/telemetry/page/page_set.py View 2 chunks +0 lines, -33 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_unittest.py View 2 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
6 years, 3 months ago (2014-09-09 21:54:20 UTC) #2
tonyg
lgtm
6 years, 3 months ago (2014-09-09 23:33:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/555843003/1
6 years, 3 months ago (2014-09-09 23:52:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8ae0814b62718737b0a406402c091e3734dfda39
6 years, 3 months ago (2014-09-10 01:42:01 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:57:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b188e83b9b316708b39381c64f46fb8ea25fdb30
Cr-Commit-Position: refs/heads/master@{#294069}

Powered by Google App Engine
This is Rietveld 408576698