Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/telemetry/telemetry/page/page_set.py

Issue 555843003: Remove PageSet.FromFile method since it's no longer used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_set_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_set.py
diff --git a/tools/telemetry/telemetry/page/page_set.py b/tools/telemetry/telemetry/page/page_set.py
index 112aeb0f08ff019da731e5731a13148defe46bde..337553244dbb7557c38b5e07bc2236a2d20477f5 100644
--- a/tools/telemetry/telemetry/page/page_set.py
+++ b/tools/telemetry/telemetry/page/page_set.py
@@ -6,7 +6,6 @@ import csv
import inspect
import os
-from telemetry.core import util
from telemetry.page import page as page_module
from telemetry.page import page_set_archive_info
from telemetry.util import cloud_storage
@@ -78,38 +77,6 @@ class PageSet(object):
page_url, self, self.base_dir))
@staticmethod
- def FromFile(file_path):
- _, ext_name = os.path.splitext(file_path)
- if ext_name == '.py':
- return PageSet.FromPythonFile(file_path)
- else:
- raise PageSetError("Pageset %s has unsupported file type" % file_path)
-
- @staticmethod
- def FromPythonFile(file_path):
- page_set_classes = []
- module = util.GetPythonPageSetModule(file_path)
- for m in dir(module):
- if m.endswith('PageSet') and m != 'PageSet':
- page_set_classes.append(getattr(module, m))
- if len(page_set_classes) != 1:
- raise PageSetError("Pageset file needs to contain exactly 1 pageset class"
- " with suffix 'PageSet'")
- page_set = page_set_classes[0]()
- for page in page_set.pages:
- page_class = page.__class__
-
- for method_name, method in inspect.getmembers(page_class,
- predicate=inspect.ismethod):
- if method_name.startswith("Run"):
- args, _, _, _ = inspect.getargspec(method)
- if not (args[0] == "self" and args[1] == "action_runner"):
- raise PageSetError("""Definition of Run<...> method of all
-pages in %s must be in the form of def Run<...>(self, action_runner):"""
- % file_path)
- return page_set
-
- @staticmethod
def _IsValidPrivacyBucket(bucket_name):
if not bucket_name:
return True
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_set_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698