Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 555703005: Revert of Telemetry: Fix exact_matches in telemetry.test_runner. (Closed)

Created:
6 years, 3 months ago by dsinclair
Modified:
6 years, 3 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org, ariblue
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Telemetry: Fix exact_matches in telemetry.test_runner. (patchset #4 id:60001 of https://codereview.chromium.org/560153004/) Reason for revert: Can't find the webrtc tests. http://build.chromium.org/p/chromium.perf/builders/Win%207%20x64%20Perf%20%281%29/builds/2649 Original issue's description: > Telemetry: Fix exact_matches in telemetry.test_runner. > > Previously, if exact_matches was True but there were no exact matches, > it would return fuzzy matches instead. This is not what the caller asked > for. > > GPU test names are changed to match the buildbot config, since they were > previously relying on fuzzy matching. > > SHERIFFS: May cause errors like: > > No test named "some_test_name". > > Available tests are: > ... > > If so, this CL can be safely reverted. > > BUG=413334, 413442 > > Committed: https://crrev.com/566ed9f6e71cea313c88e8f259eca76581b72d67 > Cr-Commit-Position: refs/heads/master@{#294757} TBR=nednguyen@google.com,ariblue@google.com,dtu@chromium.org,kbr@chromium.org,tonyg@chromium.org,jbroman@chromium.org NOTREECHECKS=true NOTRY=true BUG=413334, 413442 Committed: https://crrev.com/0994ab58a950f125c33fa2c0a078c99caaaf9202 Cr-Commit-Position: refs/heads/master@{#294812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -152 lines) Patch
M content/test/gpu/gpu_tests/gpu_process.py View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/gpu_rasterization.py View 1 chunk +2 lines, -1 line 0 comments Download
A content/test/gpu/gpu_tests/memory.py View 1 chunk +114 lines, -0 lines 0 comments Download
A content/test/gpu/gpu_tests/memory_expectations.py View 1 chunk +35 lines, -0 lines 0 comments Download
D content/test/gpu/gpu_tests/memory_test.py View 1 chunk +0 lines, -113 lines 0 comments Download
D content/test/gpu/gpu_tests/memory_test_expectations.py View 1 chunk +0 lines, -35 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/test_runner.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dsinclair
Created Revert of Telemetry: Fix exact_matches in telemetry.test_runner.
6 years, 3 months ago (2014-09-15 13:27:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/555703005/1
6 years, 3 months ago (2014-09-15 13:29:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 09b2b9350a9275ead3ed8f56129eb7f2b0d44056
6 years, 3 months ago (2014-09-15 13:31:23 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 13:34:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0994ab58a950f125c33fa2c0a078c99caaaf9202
Cr-Commit-Position: refs/heads/master@{#294812}

Powered by Google App Engine
This is Rietveld 408576698