Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 555633002: Make IDBTransaction ctor take ScriptState instead of ExecutionContext (Closed)

Created:
6 years, 3 months ago by jsbell
Modified:
6 years, 3 months ago
CC:
blink-reviews, jsbell+idb_chromium.org, dgrogan, cmumford
Project:
blink
Visibility:
Public.

Description

Make IDBTransaction ctor take ScriptState instead of ExecutionContext This looks like a no-op, but forthcoming changes to IDBPendingTransactionMonitor require this and it makes those patches much easier to understand. BUG=390704, 411532 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M Source/modules/indexeddb/IDBDatabase.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBOpenDBRequest.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.h View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/indexeddb/IDBTransactionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jsbell
Prospective chain of patches is: 1. https://codereview.chromium.org/555633002 (this patch) - ExecutionContext->ScriptState in IDBTransaction ctor 2. ...
6 years, 3 months ago (2014-09-10 21:41:38 UTC) #2
haraken
This CL LGTM. We always prefer ScriptState than ExecutionContext (except that retrieving ScriptState is a ...
6 years, 3 months ago (2014-09-11 01:02:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/555633002/1
6 years, 3 months ago (2014-09-11 01:03:41 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 02:29:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181782

Powered by Google App Engine
This is Rietveld 408576698