Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 555433002: [DevTools] Add "never show" link to emulation warning. (Closed)

Created:
6 years, 3 months ago by dgozman
Modified:
6 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Add "never show" link to emulation warning. BUG=394734 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181819

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M Source/devtools/front_end/responsiveDesignView.css View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 2 chunks +1 line, -3 lines 0 comments Download
M Source/devtools/front_end/toolbox/ResponsiveDesignView.js View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dgozman
Take a look please. Screenshot: http://pbrd.co/1CIBaYX.
6 years, 3 months ago (2014-09-08 11:22:56 UTC) #2
pfeldman
lgtm
6 years, 3 months ago (2014-09-09 16:41:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/555433002/1
6 years, 3 months ago (2014-09-09 17:25:44 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/devtools/front_end/responsiveDesignView.css: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 3 months ago (2014-09-09 17:25:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/555433002/20001
6 years, 3 months ago (2014-09-10 09:31:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26405)
6 years, 3 months ago (2014-09-10 11:42:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/555433002/20001
6 years, 3 months ago (2014-09-11 11:38:52 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 13:18:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181819

Powered by Google App Engine
This is Rietveld 408576698